Wctaiwan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150481
Change subject: Don't reuse $result
......................................................................
Don't reuse $result
Fix repurposing of variable.
Change-Id: Ie565a190ff1ea7d47633cba464bac555be80bb8a
---
M includes/ApiEditMassMessageList.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage
refs/changes/81/150481/1
diff --git a/includes/ApiEditMassMessageList.php
b/includes/ApiEditMassMessageList.php
index b879894..7e8aa97 100644
--- a/includes/ApiEditMassMessageList.php
+++ b/includes/ApiEditMassMessageList.php
@@ -63,14 +63,14 @@
'MassMessageListContentHandler::compareTargets'
) );
}
- $result = MassMessageListContentHandler::edit(
+ $editResult = MassMessageListContentHandler::edit(
$spamlist,
$description,
$newTargets,
'massmessage-api-editsummary',
$this // APIs implement IContextSource
);
- if ( !$result->isGood() ) {
+ if ( !$editResult->isGood() ) {
$this->dieStatus( $result );
}
--
To view, visit https://gerrit.wikimedia.org/r/150481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie565a190ff1ea7d47633cba464bac555be80bb8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: contenthandler
Gerrit-Owner: Wctaiwan <wctai...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
