GWicke has submitted this change and it was merged. Change subject: Fixed list handler to handle SOL-transparent tokens (comments, meta). ......................................................................
Fixed list handler to handle SOL-transparent tokens (comments, meta). * SOL = start-of-line * SOL-transparent tokens (comments, meta-tags) should not end the current list. Instead it should collect the sol-tokens separately and wait to see if a new list item shows up or if the list ends. * Moved PreHandler's isSOLTransparent function to Util and used it in both handlers. * Now, this following examples rt "correctly" (except for newline diffs that the serializer messes up in the first example) *boo <\!--boo-->*bar *boo *<\!--boo-->bar * This fix also lets en:Black_hole to RT "cleanly" (modulo syntactic whitespace diffs). This piece of that page was getting messed up before this fix: *[http://www.eso.org/public/videos/eso0846b/ 16-year long study tracks stars orbiting Milky Way black hole] *[http://www.mpe.mpg.de/ir/GC/index.php Movie of Black Hole Candidate from Max Planck Institute] {{Black holes|state=uncollapsed}} Change-Id: I1261ee63f0cf4070c9054020d325c9699545d4b5 TODO: Add parser tests that covers this behavior. --- M js/lib/ext.core.ListHandler.js M js/lib/ext.core.PreHandler.js M js/lib/mediawiki.Util.js 3 files changed, 51 insertions(+), 31 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/28231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1261ee63f0cf4070c9054020d325c9699545d4b5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org> Gerrit-Reviewer: GWicke <gwi...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
