jenkins-bot has submitted this change and it was merged.
Change subject: Improve behavior of "empty" screen in History and Saved Pages.
......................................................................
Improve behavior of "empty" screen in History and Saved Pages.
When going to History or Saved Pages, the "empty" icon and message were
flashing momentarily before showing results.
Change-Id: I721ba5506c29aa61e0a32f48ee68851986b33359
---
M wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java
M wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java
b/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java
index a0ea720..e705c09 100644
--- a/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java
@@ -115,6 +115,7 @@
public Loader<Cursor> onCreateLoader(int i, Bundle bundle) {
String selection = null;
String[] selectionArgs = null;
+ historyEmptyContainer.setVisibility(View.GONE);
if (entryFilter.getText().length() != 0) {
// FIXME: Find ways to not have to hard code column names
selection = "UPPER(history.title) LIKE UPPER(?)";
diff --git
a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
index 447ecfb..5b99b02 100644
--- a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
@@ -183,6 +183,7 @@
public Loader<Cursor> onCreateLoader(int i, Bundle bundle) {
String selection = null;
String[] selectionArgs = null;
+ savedPagesEmptyContainer.setVisibility(View.GONE);
if (entryFilter.getText().length() != 0) {
// FIXME: Find ways to not have to hard code column names
selection = "UPPER(savedpages.title) LIKE UPPER(?)";
--
To view, visit https://gerrit.wikimedia.org/r/150595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I721ba5506c29aa61e0a32f48ee68851986b33359
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
