Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/150991

Change subject: HHVM: set an empty string as the value for hhvm.pid_file
......................................................................

HHVM: set an empty string as the value for hhvm.pid_file

If hhvm.pid_file is unset, HHVM uses a default PID file path. To convince HHVM
not to try and manage its PID file at all, we need to set an empty string.

Change-Id: If7e8af3df3e87b169f3a0ed5b16ec0b57fc4b9d7
---
M modules/hhvm/manifests/init.pp
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/91/150991/1

diff --git a/modules/hhvm/manifests/init.pp b/modules/hhvm/manifests/init.pp
index 069c956..80d8a3e 100644
--- a/modules/hhvm/manifests/init.pp
+++ b/modules/hhvm/manifests/init.pp
@@ -69,11 +69,12 @@
     $common_defaults = {
         date => { timezone => 'UTC' },
         hhvm => {
-            mysql                    => { typed_results => false },
-            include_path             => '.:/usr/share/php:/usr/share/pear',
             dynamic_extension_path   => '/usr/lib/hphp/extensions/20140702',
             enable_obj_destruct_call => true,
             enable_zend_compat       => true,
+            include_path             => '.:/usr/share/php:/usr/share/pear',
+            mysql                    => { typed_results => false },
+            pid_file                 => '',  # PID file managed by 
start-stop-daemon(8)
             log                      => {
                 always_log_unhandled_exceptions => true,
                 header                          => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/150991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7e8af3df3e87b169f3a0ed5b16ec0b57fc4b9d7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to