jenkins-bot has submitted this change and it was merged.
Change subject: new CoordImportRobot.has_coord_qualifier() method
......................................................................
new CoordImportRobot.has_coord_qualifier() method
to check if the 'coordinates' property is already used as qualifier for
another claim and, in that case, avoid adding that property again.
also done some minor cleanup
bug: 65430
Change-Id: I0759cca01de15a6884708341e79cd3403b4af74e
---
M scripts/coordinate_import.py
1 file changed, 39 insertions(+), 15 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
Multichill: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py
index 160686a..75cfe06 100644
--- a/scripts/coordinate_import.py
+++ b/scripts/coordinate_import.py
@@ -42,11 +42,26 @@
self.generator = pagegenerators.PreloadingGenerator(generator)
self.repo = pywikibot.Site().data_repository()
self.cacheSources()
+ self.prop = 'P625'
+
+ def has_coord_qualifier(self, claims):
+ """
+ Check if self.prop is used as property for a qualifier.
+
+ @param claims: the Wikibase claims to check in
+ @type claims: dict
+ @return: the first property for which self.prop
+ is used as qualifier, or None if any
+ @returntype: unicode or None
+
+ """
+ for prop in claims:
+ for claim in claims[prop]:
+ if self.prop in claim.qualifiers:
+ return prop
def run(self):
- """
- Starts the robot.
- """
+ """Start the robot."""
for page in self.generator:
pywikibot.output(u'Working on %s' % page.title())
item = pywikibot.ItemPage.fromPage(page)
@@ -57,20 +72,29 @@
if coordinate:
claims = item.get().get('claims')
- if u'P625' in claims:
- pywikibot.output(u'Item %s already contains
coordinates (P625)' % item.title())
+ if self.prop in claims:
+ pywikibot.output(u'Item %s already contains
coordinates (%s)'
+ % (item.title(), self.prop))
else:
- newclaim = pywikibot.Claim(self.repo, u'P625')
- newclaim.setTarget(coordinate)
- pywikibot.output(u'Adding %s, %s to %s' %
(coordinate.lat, coordinate.lon, item.title()))
- try:
- item.addClaim(newclaim)
+ prop = self.has_coord_qualifier(claims)
+ if prop:
+ pywikibot.output(u'Item %s already contains
coordinates'
+ u' (%s) as qualifier for %s'
+ % (item.title(), self.prop, prop))
+ else:
+ newclaim = pywikibot.Claim(self.repo, self.prop)
+ newclaim.setTarget(coordinate)
+ pywikibot.output(u'Adding %s, %s to %s' %
(coordinate.lat,
+
coordinate.lon,
+
item.title()))
+ try:
+ item.addClaim(newclaim)
- source = self.getSource(page.site)
- if source:
- newclaim.addSource(source, bot=True)
- except CoordinateGlobeUnknownException as e:
- pywikibot.output(u'Skipping unsupported globe: %s'
% e.args)
+ source = self.getSource(page.site)
+ if source:
+ newclaim.addSource(source, bot=True)
+ except CoordinateGlobeUnknownException as e:
+ pywikibot.output(u'Skipping unsupported globe:
%s' % e.args)
def main():
--
To view, visit https://gerrit.wikimedia.org/r/148686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0759cca01de15a6884708341e79cd3403b4af74e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisa...@openmailbox.org>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: Multichill <maar...@mdammers.nl>
Gerrit-Reviewer: Ricordisamoa <ricordisa...@openmailbox.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
