Vikassy has uploaded a new change for review. https://gerrit.wikimedia.org/r/151419
Change subject: Added browser tests for Formula ...................................................................... Added browser tests for Formula Change-Id: I96a7dfd09336ae919775f7d0234dd9c11ce93268 --- M modules/ve-mw/tests/browser/features/language_screenshot.feature M modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 3 files changed, 32 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/19/151419/1 diff --git a/modules/ve-mw/tests/browser/features/language_screenshot.feature b/modules/ve-mw/tests/browser/features/language_screenshot.feature index bcbaa63..b4ee1d9 100644 --- a/modules/ve-mw/tests/browser/features/language_screenshot.feature +++ b/modules/ve-mw/tests/browser/features/language_screenshot.feature @@ -120,4 +120,8 @@ When I click on category in hamburger menu Then I should see category dialog box - + Scenario: VisualEditor_formula + Given I go to the "Formula Screenshot" page with source content "" + When I click on Formula option in Insert menu + And I type a formula + Then I should see the formula insertion menu diff --git a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb index 58ff19b..f0e14f6 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb @@ -46,6 +46,10 @@ on(VisualEditorPage).media_alternative_text_element.when_present.send_keys content end +Given(/^I go to "(.*?)" page containing math formula/) do |page_title| + step "I go to the \"#{page_title}\" page with source content \"<math>2+2</math>\"" +end + When(/^I click on the Insert menu$/) do on(VisualEditorPage).insert_menu_element.when_present.click end @@ -93,6 +97,15 @@ When(/^I click on category in hamburger menu$/) do step "I click the hamburger menu" on(VisualEditorPage).category_link_element.when_present.click +end + +When(/^I click on Formula option in Insert menu$/) do + step "I click on the Insert menu" + on(VisualEditorPage).formula_link_element.when_present.click +end + +When(/^I type a formula$/) do + on(VisualEditorPage).formula_area_element.when_present.send_keys "2+2" end Then(/^I should see category dialog box$/) do @@ -150,11 +163,13 @@ capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element]) - capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_heading_element, @current_page.prevent_redirect_element], @current_page.iframe_element, 0) + capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_heading_element, @current_page.prevent_redirect_element, @current_page.page_settings_gap_element], @current_page.iframe_element, 0) capture_screenshot("VisualEditor_Page_Settings_TOC-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.table_of_contents_element], @current_page.iframe_element, 0) capture_screenshot("VisualEditor_Page_Settings_Edit_Links-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_editlinks_element], @current_page.iframe_element, 0) + + capture_screenshot("VisualEditor_Apply_Changes-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.settings_apply_button_element], @current_page.iframe_element, 3) end Then(/^I should see list and indentation dropdown$/) do @@ -219,3 +234,9 @@ on(VisualEditorPage).toolbar_element.when_present.should be_visible capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.right_navigation_element, @current_page.left_navigation_element, @current_page.toolbar_element]) end + +Then(/^I should see the formula insertion menu$/) do + on(VisualEditorPage).iframe_element.when_present.should be_visible + sleep 5 + capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element, @current_page.formula_image_element], nil, 0) +end \ No newline at end of file diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index ba5c175..c3d73c1 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -47,7 +47,8 @@ div(:left_navigation, id: "left-navigation") div(:toolbar, class: "ve-init-mw-viewPageTarget-toolbar") span(:category_link, class: "oo-ui-iconedElement-icon oo-ui-icon-tag") - + a(:formula_link, css: "span.oo-ui-tool-name-math > a.oo-ui-tool-link") + img(:formula_image, class: "mwe-math-fallback-png-inline") if ENV["BROWSER"] == "chrome" div(:tools_menu, class: "oo-ui-widget oo-ui-widget-enabled oo-ui-toolGroup oo-ui-iconedElement oo-ui-popupToolGroup oo-ui-listToolGroup") @@ -132,6 +133,9 @@ div(:media_alternative_block, class: "oo-ui-layout oo-ui-iconedElement oo-ui-labeledElement oo-ui-fieldsetLayout", index: 1, frame: frame) list_item(:media_advanced_settings, class: "oo-ui-widget oo-ui-widget-enabled oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-outlineItemWidget oo-ui-outlineItemWidget-level-0 oo-ui-iconedElement oo-ui-labeledElement", frame: frame) a(:insert_media, css: "div.oo-ui-processDialog-actions-primary > div.oo-ui-buttonedElement-frameless > a", frame: frame) + text_area(:formula_area, class: "oo-ui-ltr", frame: frame) + div(:settings_apply_button, class: "oo-ui-processDialog-actions-primary", frame: frame) + div(:page_settings_gap, class: "oo-ui-layout oo-ui-panelLayout oo-ui-panelLayout-scrollable oo-ui-panelLayout-expanded oo-ui-stackLayout oo-ui-bookletLayout-stackLayout", frame: frame) end # not having beta warning makes iframes off by one -- To view, visit https://gerrit.wikimedia.org/r/151419 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I96a7dfd09336ae919775f7d0234dd9c11ce93268 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Vikassy <vikasyaligar...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits