Daniel Werner has submitted this change and it was merged.
Change subject: Fix for maximum number of loops applied even if set to unlimited
......................................................................
Fix for maximum number of loops applied even if set to unlimited
Change-Id: I588b6f0a9ac393051f71bbe97717074c8a53a9b5
ExtLoops::maxLoopsPerformed was buggy. It has to check the config var, not the
loop counter.
---
M Loops.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Daniel Werner: Verified; Looks good to me, approved
diff --git a/Loops.php b/Loops.php
index b75ffb1..d14ad0a 100644
--- a/Loops.php
+++ b/Loops.php
@@ -333,8 +333,7 @@
* @return bool
*/
public static function maxLoopsPerformed( Parser &$parser ) {
- $count = $parser->mExtLoopsCounter;
- return $count > -1 && $count >= self::$maxLoops;
+ return self::$maxLoops > -1 && $parser->mExtLoopsCounter >=
self::$maxLoops;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/147410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I588b6f0a9ac393051f71bbe97717074c8a53a9b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Loops
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Daniel Werner <daniel.a.r.wer...@gmail.com>
Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com>
Gerrit-Reviewer: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
