jenkins-bot has submitted this change and it was merged.
Change subject: Remove score functionality from Cirrus, similar to core's
I00acaaba
......................................................................
Remove score functionality from Cirrus, similar to core's I00acaaba
Change-Id: Ied61651045c22635114c4ac4994a7d9651ba1d9f
---
M CirrusSearch.php
M includes/Search/Result.php
2 files changed, 0 insertions(+), 14 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CirrusSearch.php b/CirrusSearch.php
index b2a0773..ea99039 100644
--- a/CirrusSearch.php
+++ b/CirrusSearch.php
@@ -309,9 +309,6 @@
// their primary search engine.
$wgCirrusSearchEnablePref = false;
-// Should Cirrus show the score?
-$wgCirrusSearchShowScore = false;
-
// CirrusSearch interwiki searching
// Keys are the interwiki prefix, values are the index to search
// Results are cached.
diff --git a/includes/Search/Result.php b/includes/Search/Result.php
index def3d51..add5b64 100644
--- a/includes/Search/Result.php
+++ b/includes/Search/Result.php
@@ -35,7 +35,6 @@
private $interwiki = '', $interwikiNamespace = '';
private $wordCount;
private $byteSize;
- private $score;
private $timestamp;
/**
@@ -46,8 +45,6 @@
* @param $result \Elastic\Result containing information about the
result this class should represent
*/
public function __construct( $results, $result, $interwiki = '' ) {
- global $wgCirrusSearchShowScore;
-
if ( $interwiki ) {
$this->setInterwiki( $result, $interwiki );
}
@@ -89,10 +86,6 @@
if ( isset( $highlights[ 'heading' ] ) ) {
$this->sectionSnippet = $this->escapeHighlightedText(
$highlights[ 'heading' ][ 0 ] );
$this->sectionTitle = $this->findSectionTitle();
- }
-
- if ( $wgCirrusSearchShowScore && $results->getMaxScore() ) {
- $this->score = $result->getScore() /
$results->getMaxScore();
}
}
@@ -261,10 +254,6 @@
public function getByteSize() {
return $this->byteSize;
- }
-
- public function getScore() {
- return $this->score;
}
public function getTimestamp() {
--
To view, visit https://gerrit.wikimedia.org/r/152288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied61651045c22635114c4ac4994a7d9651ba1d9f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
