jenkins-bot has submitted this change and it was merged.
Change subject: Clean up data replacement in the translate_messageindex table
......................................................................
Clean up data replacement in the translate_messageindex table
* Avoid letting callers see the table being briefly empty.
* Also made the REPLACE and INSERT since everything is always deleted first.
Change-Id: Ic80d21b6abe6aa076359b3b277f2b6b527af63c9
---
M utils/MessageIndex.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/utils/MessageIndex.php b/utils/MessageIndex.php
index 9ef5ed6..8601728 100644
--- a/utils/MessageIndex.php
+++ b/utils/MessageIndex.php
@@ -363,8 +363,10 @@
$rows[] = array( 'tmi_key' => $key, 'tmi_value' =>
$value );
}
+ $dbw->startAtomic( __METHOD__ );
$dbw->delete( 'translate_messageindex', '*', __METHOD__ );
- $dbw->replace( 'translate_messageindex', array( array(
'tmi_key' ) ), $rows, __METHOD__ );
+ $dbw->insert( 'translate_messageindex', $rows, __METHOD__ );
+ $dbw->endAtomic( __METHOD__ );
$this->index = $array;
wfProfileOut( __METHOD__ );
--
To view, visit https://gerrit.wikimedia.org/r/153733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic80d21b6abe6aa076359b3b277f2b6b527af63c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
