jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Dont use magic
......................................................................
Hygiene: Dont use magic
These variables were not being set on the Article like you might expect,
Article::__set passes these through to the contained mPage object for
"backward compatibility" reasons.
Instead of using magic set them directly.
Change-Id: I1877bb21aa5c69ff9b83db6cf6d0eaaf51912581
---
M includes/Content/Content.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
Objections:
Spage: There's a problem with this change, please improve
diff --git a/includes/Content/Content.php b/includes/Content/Content.php
index 4f27d6c..c2475be 100644
--- a/includes/Content/Content.php
+++ b/includes/Content/Content.php
@@ -54,8 +54,8 @@
$newRev = $occupationController->ensureFlowRevision(
$article, $loader->getWorkflow() );
if ( $newRev ) {
- $article->mRevision = $newRev;
- $article->mContentObject =
$newRev->getContent();
+ $article->getPage()->mRevision = $newRev;
+ $article->getPage()->mContentObject =
$newRev->getContent();
$contentObject = $newRev->getContent();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/151248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1877bb21aa5c69ff9b83db6cf6d0eaaf51912581
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
