Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153803
Change subject: WIP: Use OverlayManager for talk Overlay
......................................................................
WIP: Use OverlayManager for talk Overlay
Allow linking to mobile talk page.
Bug: 52165
Change-Id: Icad19b1c18efe3e45fe86efde2c6217f6d9cd617
---
M javascripts/modules/talk/talk.js
1 file changed, 18 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/03/153803/1
diff --git a/javascripts/modules/talk/talk.js b/javascripts/modules/talk/talk.js
index 1922d94..3a0e4d2 100644
--- a/javascripts/modules/talk/talk.js
+++ b/javascripts/modules/talk/talk.js
@@ -4,25 +4,30 @@
M.assertMode( [ 'beta', 'alpha', 'app' ] );
function onTalkClick( ev ) {
- var talkPage = $( this ).data( 'title' ),
- loadingOverlay = new LoadingOverlay();
-
ev.preventDefault();
- loadingOverlay.show();
- mw.loader.using( 'mobile.talk.common', function() {
- var TalkOverlay = M.require( 'modules/talk/TalkOverlay'
);
-
- loadingOverlay.hide();
- new TalkOverlay( {
- title: talkPage
- } );
- } );
}
function init( title ) {
var talkPrefix = mw.config.get( 'wgFormattedNamespaces' )[
mw.config.get( 'wgNamespaceNumber' ) + 1 ] + ':';
+
+ M.overlayManager.add( /^talk\//, function() {
+ var result = $.Deferred(), loadingOverlay = new
LoadingOverlay();
+ loadingOverlay.show();
+ mw.loader.using( 'mobile.talk.common', function() {
+ var TalkOverlay = M.require(
'modules/talk/TalkOverlay' );
+
+ loadingOverlay.hide();
+ result.resolve(
+ new TalkOverlay( {
+ title: talkPrefix + title
+ } )
+ );
+ } );
+
+ return result;
+ } );
// FIXME change when micro.tap.js in stable
- $( '#ca-talk' ).on( M.tapEvent( 'click' ), onTalkClick ).data(
'title', talkPrefix + title );
+ $( '#ca-talk' ).children( 'a' ).attr( 'href', '#talk/' );
// enable Talk button (only to hide when JS disabled)
$( '#ca-talk' ).removeClass( 'hidden' );
}
--
To view, visit https://gerrit.wikimedia.org/r/153803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icad19b1c18efe3e45fe86efde2c6217f6d9cd617
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
