Jjanes has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154338
Change subject: PHPUnit: Add Database tags
......................................................................
PHPUnit: Add Database tags
Several unit tests access the database, but did not declare
themselves in the Database @group. This causes
"make databaseless" to fail needlessly. Add the
missing tags.
tests/phpunit/includes/LinkerTest.php
tests/phpunit/includes/actions/ActionTest.php
tests/phpunit/includes/specials/SpecialListFilesTest.php
tests/phpunit/includes/specials/SpecialMIMESearchTest.php
tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
Other than ActionTest.php, these also are problematic in 1.23
Change-Id: I7c1c957e2194c13e48b7ba68d7529e5d89901875
---
M tests/phpunit/includes/LinkerTest.php
M tests/phpunit/includes/actions/ActionTest.php
M tests/phpunit/includes/specials/SpecialListFilesTest.php
M tests/phpunit/includes/specials/SpecialMIMESearchTest.php
M tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
5 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/38/154338/1
diff --git a/tests/phpunit/includes/LinkerTest.php
b/tests/phpunit/includes/LinkerTest.php
index 72114e9..32c0eb6 100644
--- a/tests/phpunit/includes/LinkerTest.php
+++ b/tests/phpunit/includes/LinkerTest.php
@@ -1,5 +1,10 @@
<?php
+/**
+ * @group Database
+*/
+
+
class LinkerTest extends MediaWikiLangTestCase {
/**
diff --git a/tests/phpunit/includes/actions/ActionTest.php
b/tests/phpunit/includes/actions/ActionTest.php
index eb370d9..cc6fb11 100644
--- a/tests/phpunit/includes/actions/ActionTest.php
+++ b/tests/phpunit/includes/actions/ActionTest.php
@@ -7,6 +7,7 @@
* @author Thiemo Mättig
*
* @group Action
+ * @group Database
*/
class ActionTest extends MediaWikiTestCase {
diff --git a/tests/phpunit/includes/specials/SpecialListFilesTest.php
b/tests/phpunit/includes/specials/SpecialListFilesTest.php
index c042064..ec2218d 100644
--- a/tests/phpunit/includes/specials/SpecialListFilesTest.php
+++ b/tests/phpunit/includes/specials/SpecialListFilesTest.php
@@ -6,6 +6,7 @@
* Copyright © 2013, Siebrand Mazeland
* Copyright © 2013, Wikimedia Foundation Inc.
*
+ * @group Database
*/
class SpecialListFilesTest extends MediaWikiTestCase {
diff --git a/tests/phpunit/includes/specials/SpecialMIMESearchTest.php
b/tests/phpunit/includes/specials/SpecialMIMESearchTest.php
index bd95281..dcb3d2b 100644
--- a/tests/phpunit/includes/specials/SpecialMIMESearchTest.php
+++ b/tests/phpunit/includes/specials/SpecialMIMESearchTest.php
@@ -1,4 +1,8 @@
<?php
+/**
+* @group Database
+*/
+
class SpecialMIMESearchTest extends MediaWikiTestCase {
/** @var MIMESearchPage */
diff --git a/tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
b/tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
index b13df89..38395c1 100644
--- a/tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
+++ b/tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php
@@ -24,6 +24,7 @@
* @covers MediaWikiPageLinkRenderer
*
* @group Title
+ * @group Database
*/
class MediaWikiPageLinkRendererTest extends MediaWikiTestCase {
--
To view, visit https://gerrit.wikimedia.org/r/154338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c1c957e2194c13e48b7ba68d7529e5d89901875
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jjanes <jeff.ja...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
