Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154400
Change subject: Fix moment tests
......................................................................
Fix moment tests
moment.js has a slight change in date output which broke some tests.
Change-Id: If5ffdaba8574e574d644f3d8bd987ee29aeb0bc9
---
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/00/154400/1
diff --git a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
index 3bb5a1f..0f091ab 100644
--- a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
+++ b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
@@ -173,7 +173,7 @@
assert.strictEqual( panel.creditField.$element.find(
'.mw-mmv-author' ).text(), imageData.author, 'Author text is correctly set' );
assert.strictEqual( panel.creditField.$element.find(
'.mw-mmv-source' ).html(), 'Lost<a href="foo">Bar</a>', 'Source text is
correctly set' );
assert.strictEqual( panel.creditField.$element.attr(
'original-title' ), 'Author and source information', 'Source tooltip is
correctly set' );
- assert.ok( panel.$datetime.text().indexOf( 'August 26 2013' ) >
0, 'Correct date is displayed' );
+ assert.ok( panel.$datetime.text().indexOf( 'August 26, 2013' )
> 0, 'Correct date is displayed' );
assert.strictEqual( panel.$license.text(), 'CC BY 2.0',
'License is correctly set' );
assert.ok( panel.$license.prop( 'target' ), 'License
information opens in new window' );
assert.ok( panel.$username.text().indexOf(
imageData.lastUploader ) > 0, 'Correct username is displayed' );
@@ -181,7 +181,7 @@
imageData.creationDateTime = undefined;
panel.setImageInfo( image, imageData, repoData, localUsage,
globalUsage, gender );
- assert.ok( panel.$datetime.text().indexOf( 'August 25 2013' ) >
0, 'Correct date is displayed' );
+ assert.ok( panel.$datetime.text().indexOf( 'August 25, 2013' )
> 0, 'Correct date is displayed' );
window.moment = oldMoment;
} );
--
To view, visit https://gerrit.wikimedia.org/r/154400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5ffdaba8574e574d644f3d8bd987ee29aeb0bc9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
