[MediaWiki-commits] [Gerrit] Remove dead stuff from MW/ruleset.xml - change (mediawiki...codesniffer)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154402

Change subject: Remove dead stuff from MW/ruleset.xml
......................................................................

Remove dead stuff from MW/ruleset.xml

Also reorder / group by sniff types

Change-Id: I5b028d282a7e8716d14e6032a7092250d08479f7
---
M MediaWiki/ruleset.xml
1 file changed, 4 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/02/154402/1

diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 94fb91f..7036716 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -6,10 +6,8 @@
        - 
https://github.com/squizlabs/PHP_CodeSniffer/tree/master/CodeSniffer/Standards
 -->
 <ruleset name="MediaWiki">
+
        <rule ref="Generic.Classes.DuplicateClassName" />
-       <!-- Some people likes else { /** comment */ }
-       <rule ref="Generic.CodeAnalysis.EmptyStatement" />
-       -->
        <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" />
        <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall" />
        <rule ref="Generic.CodeAnalysis.JumbledIncrementer" />
@@ -18,10 +16,6 @@
        <!--
                https://pear.php.net/bugs/bug.php?id=19950
                <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
-       -->
-       <!--
-         Useless rule. Test is naïve and flags perfectly legit reasons to 
override
-         <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
        -->
        <rule ref="Generic.Files.ByteOrderMark" />
        <rule ref="Generic.Files.EndFileNewline" />
@@ -40,12 +34,6 @@
        <rule 
ref="Generic.Formatting.MultipleStatementAlignment.NotSameWarning">
                <severity>0</severity>
        </rule>
-       <!--
-               Community is undecided about (type) $cast vs. (type)$cast (bug 
48450).
-               <rule ref="Generic.Formatting.SpaceAfterCast" />
-       -->
-       <!-- Use "(type)" instead of "( type )" -->
-       <rule ref="Squiz.WhiteSpace.CastSpacing" />
        <rule ref="Generic.Functions.CallTimePassByReference" />
        <rule ref="Generic.Functions.FunctionCallArgumentSpacing" />
        <rule 
ref="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma">
@@ -60,7 +48,6 @@
        <!-- <rule ref="Generic.NamingConventions.CamelCapsFunctionName" /> -->
        <rule ref="Generic.NamingConventions.ConstructorName" />
        <rule ref="Generic.NamingConventions.UpperCaseConstantName" />
-       <!-- <rule ref="Generic.PHP.CharacterBeforePHPOpeningTag" /> -->
        <rule ref="Generic.PHP.DeprecatedFunctions" />
        <rule ref="Generic.PHP.DisallowShortOpenTag" />
        <rule ref="Generic.PHP.ForbiddenFunctions" />
@@ -85,20 +72,13 @@
        <rule ref="Squiz.Scope.StaticThisUsage" />
        <rule ref="Squiz.WhiteSpace.LanguageConstructSpacing" />
        <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing" />
-       <!-- <rule ref="Squiz.WhiteSpace.MemberVarSpacing" /> -->
-       <!--
-               `$foo -> bar()` is bad. But we do allow:
-               $foo
-                       ->bar()
-                       ->quux();
-               <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing" />
-       -->
-       <!-- There is no consensus on how to apply this rule, so disabled -->
-       <!--rule ref="Squiz.WhiteSpace.OperatorSpacing" /-->
        <rule ref="Squiz.WhiteSpace.ScopeClosingBrace" />
        <rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing" />
        <rule ref="Squiz.WhiteSpace.SemicolonSpacing" />
        <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace" />
+       <!-- Use "(type)" instead of "( type )" -->
+       <rule ref="Squiz.WhiteSpace.CastSpacing" />
 
        <rule ref="Zend.Files.ClosingTag" />
+
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/154402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b028d282a7e8716d14e6032a7092250d08479f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits