[MediaWiki-commits] [Gerrit] Fix phpcs errors in tests dir - change (mediawiki/core)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154404

Change subject: Fix phpcs errors in tests dir
......................................................................

Fix phpcs errors in tests dir

Change-Id: I79fa3b8f92e958f4a0dc4fe892703f37d711ca95
---
M tests/phpunit/includes/api/ApiRevisionDeleteTest.php
M tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
M tests/qunit/data/generateJqueryMsgData.php
M tests/testHelpers.inc
4 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/154404/1

diff --git a/tests/phpunit/includes/api/ApiRevisionDeleteTest.php 
b/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
index 21f4322..b03836e 100644
--- a/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
+++ b/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
@@ -9,8 +9,8 @@
  */
 class ApiRevisionDeleteTest extends ApiTestCase {
 
-       static $page = 'Help:ApiRevDel_test';
-       var $revs = array();
+       public static $page = 'Help:ApiRevDel_test';
+       public $revs = array();
 
        protected function setUp() {
                // Needs to be before setup since this gets cached
diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php 
b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
index 64e2b00..6ca4793 100644
--- a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
+++ b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
@@ -7,7 +7,12 @@
 
                // The return value of the closure shouldn't matter since this 
test should
                // never call it
-               SkinFactory::getDefaultInstance()->register( 'fakeskin', 
'FakeSkin', function(){});
+               SkinFactory::getDefaultInstance()->register(
+                       'fakeskin',
+                       'FakeSkin',
+                       function(){
+                       }
+               );
        }
 
        /**
diff --git a/tests/qunit/data/generateJqueryMsgData.php 
b/tests/qunit/data/generateJqueryMsgData.php
index 461ab87..61ebbf8 100644
--- a/tests/qunit/data/generateJqueryMsgData.php
+++ b/tests/qunit/data/generateJqueryMsgData.php
@@ -65,7 +65,7 @@
 
 class GenerateJqueryMsgData extends Maintenance {
 
-       static $keyToTestArgs = array(
+       public static $keyToTestArgs = array(
                'undelete_short' => array(
                        array( 0 ),
                        array( 1 ),
diff --git a/tests/testHelpers.inc b/tests/testHelpers.inc
index 6d94435..2f5fa9e 100644
--- a/tests/testHelpers.inc
+++ b/tests/testHelpers.inc
@@ -51,8 +51,8 @@
 }
 
 class TestRecorder implements ITestRecorder {
-       var $parent;
-       var $term;
+       public $parent;
+       public $term;
 
        function __construct( $parent ) {
                $this->parent = $parent;
@@ -295,7 +295,7 @@
 }
 
 class DbTestRecorder extends DbTestPreviewer {
-       var $version;
+       public $version;
 
        /**
         * Set up result recording; insert a record for the run with the date

-- 
To view, visit https://gerrit.wikimedia.org/r/154404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79fa3b8f92e958f4a0dc4fe892703f37d711ca95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits