jenkins-bot has submitted this change and it was merged. Change subject: Wrap CentralAuthUser::attach in an explicit transaction ......................................................................
Wrap CentralAuthUser::attach in an explicit transaction Change-Id: I715c3e2b77ba28efc36a375ee214021f1334a1d1 --- M CentralAuthUser.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Hoo man: Looks good to me, approved jenkins-bot: Verified diff --git a/CentralAuthUser.php b/CentralAuthUser.php index 7c14fa8..0d4d395 100644 --- a/CentralAuthUser.php +++ b/CentralAuthUser.php @@ -1408,6 +1408,7 @@ */ public function attach( $wikiID, $method = 'new', $sendToRC = true ) { $dbw = self::getCentralDB(); + $dbw->begin( __METHOD__ ); $dbw->insert( 'localuser', array( 'lu_wiki' => $wikiID, @@ -1418,6 +1419,7 @@ array( 'IGNORE' ) ); $success = $dbw->affectedRows() === 1; + $dbw->commit( __METHOD__ ); if ( $wikiID === wfWikiID() ) { $this->resetState(); -- To view, visit https://gerrit.wikimedia.org/r/154443 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715c3e2b77ba28efc36a375ee214021f1334a1d1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CentralAuth Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits