jenkins-bot has submitted this change and it was merged.
Change subject: Do not use VERP on group sending of Emails
......................................................................
Do not use VERP on group sending of Emails
Generating unique return path for every single email in a $to array
can cause issues. Hence disabling the feature
Change-Id: I046440c1f95c409adb0dfc584adbddc66d18f1b1
---
M BounceHandlerHooks.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/BounceHandlerHooks.php b/BounceHandlerHooks.php
index cec0d1a..14c6605 100644
--- a/BounceHandlerHooks.php
+++ b/BounceHandlerHooks.php
@@ -16,9 +16,8 @@
if ( is_object( $recip ) ) {
self::generateVerp( $recip, $returnPath );
} else if ( is_array( $recip ) ){
- foreach( $recip as $to ) {
- self::generateVerp( $to, $returnPath );
- }
+ // Generating VERP address for a batch of send emails
is complex. This feature is hence disabled
+ return true;
} else {
throw new InvalidArgumentException( "Expected
MailAddress object or an array of MailAddress, got $recip" );
}
--
To view, visit https://gerrit.wikimedia.org/r/154446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I046440c1f95c409adb0dfc584adbddc66d18f1b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BounceHandler
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <01tonytho...@gmail.com>
Gerrit-Reviewer: Jgreen <jgr...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
