Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154475
Change subject: WebInstallerOutput: Restore mistakenly deleted 'global
$wgResourceModules'
......................................................................
WebInstallerOutput: Restore mistakenly deleted 'global $wgResourceModules'
Deleted in 301a7f3d, previously added in a96afeb2.
Change-Id: If0889bc003320abd0b74fc57b8975255f0efcc7e
---
M includes/installer/WebInstallerOutput.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/75/154475/1
diff --git a/includes/installer/WebInstallerOutput.php
b/includes/installer/WebInstallerOutput.php
index 174120f..c3b40e2 100644
--- a/includes/installer/WebInstallerOutput.php
+++ b/includes/installer/WebInstallerOutput.php
@@ -126,6 +126,9 @@
public function getCSS() {
// Horrible, horrible hack: the installer is currently
hardcoded to use the Vector skin, so load
// it here. Include instead of require, as this will work
without it, it will just look bad.
+ // We need the 'global' statement for $wgResourceModules
because the Vector skin adds the
+ // definitions for its RL modules there that we use implicitly
below.
+ global $wgResourceModules; // This is NOT UNUSED!
global $wgStyleDirectory;
include_once "$wgStyleDirectory/Vector/Vector.php";
--
To view, visit https://gerrit.wikimedia.org/r/154475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If0889bc003320abd0b74fc57b8975255f0efcc7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
