jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: I06f550f3d1cf343934d453b3acebb1f5b6df2019
---
M DPL.php
M DPLArticle.php
M DPLListMode.php
M DPLLogger.php
4 files changed, 56 insertions(+), 56 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DPL.php b/DPL.php
index a20c7df..8a2d5cd 100644
--- a/DPL.php
+++ b/DPL.php
@@ -4,27 +4,27 @@
class DPL {
- var $mArticles;
- var $mHeadingType; // type of heading: category, user, etc.
(depends on 'ordermethod' param)
- var $mHListMode; // html list mode for headings
- var $mListMode; // html list mode for pages
- var $mEscapeLinks; // whether to escape img/cat or not
- var $mAddExternalLink; // whether to add the text of an external link
or not
- var $mIncPage; // true only if page transclusion is enabled
- var $mIncMaxLen; // limit for text to include
- var $mIncSecLabels = array(); // array of labels of sections to
transclude
- var $mIncSecLabelsMatch = array(); // array of match patterns for
sections to transclude
- var $mIncSecLabelsNotMatch = array(); // array of NOT match patterns
for sections to transclude
- var $mIncParsed; // whether to match raw parameters or parsed
contents
- var $mParser;
- var $mParserOptions;
- var $mParserTitle;
- var $mLogger; // DPLLogger
- var $mOutput;
- var $mReplaceInTitle;
- var $filteredCount = 0; // number of (filtered) row count
- var $nameSpaces;
- var $mTableRow; // formatting rules for table fields
+ public $mArticles;
+ public $mHeadingType; // type of heading: category, user, etc.
(depends on 'ordermethod' param)
+ public $mHListMode; // html list mode for headings
+ public $mListMode; // html list mode for pages
+ public $mEscapeLinks; // whether to escape img/cat or not
+ public $mAddExternalLink; // whether to add the text of an external
link or not
+ public $mIncPage; // true only if page transclusion is
enabled
+ public $mIncMaxLen; // limit for text to include
+ public $mIncSecLabels = array(); // array of labels of sections
to transclude
+ public $mIncSecLabelsMatch = array(); // array of match patterns for
sections to transclude
+ public $mIncSecLabelsNotMatch = array(); // array of NOT match patterns
for sections to transclude
+ public $mIncParsed; // whether to match raw parameters or parsed
contents
+ public $mParser;
+ public $mParserOptions;
+ public $mParserTitle;
+ public $mLogger; // DPLLogger
+ public $mOutput;
+ public $mReplaceInTitle;
+ public $filteredCount = 0; // number of (filtered) row count
+ public $nameSpaces;
+ public $mTableRow; // formatting rules for table fields
function __construct($headings, $bHeadingCount, $iColumns, $iRows,
$iRowSize, $sRowColFormat, $articles, $headingtype, $hlistmode,
$listmode, $bescapelinks, $baddexternallink,
$includepage, $includemaxlen, $includeseclabels, $includeseclabelsmatch,
diff --git a/DPLArticle.php b/DPLArticle.php
index 4ccd256..57a4f51 100644
--- a/DPLArticle.php
+++ b/DPLArticle.php
@@ -2,29 +2,29 @@
// Simple Article/Page class with properties used in the DPL
class DPLArticle {
- var $mTitle = ''; // title
- var $mNamespace = -1; // namespace (number)
- var $mID = 0; // page_id
- var $mSelTitle = ''; // selected title of initial page
- var $mSelNamespace = -1;// selected namespace (number) of initial page
- var $mImageSelTitle = ''; // selected title of image
- var $mLink = ''; // html link to page
- var $mExternalLink = '';// external link on the page
- var $mStartChar = ''; // page title first char
- var $mParentHLink = ''; // heading (link to the associated page) that
page belongs to in the list (default '' means no heading)
- var $mCategoryLinks = array(); // category links in the page
- var $mCategoryTexts = array(); // category names (without link) in the
page
- var $mCounter = ''; // Number of times this page has been viewed
- var $mSize = ''; // Article length in bytes of wiki text
- var $mDate = ''; // timestamp depending on the user's
request (can be first/last edit, page_touched, ...)
- var $myDate = ''; // the same, based on user format
definition
- var $mRevision = ''; // the revision number if specified
- var $mUserLink = ''; // link to editor (first/last, depending on
user's request) 's page or contributions if not registered
- var $mUser = ''; // name of editor (first/last,
depending on user's request) or contributions if not registered
- var $mComment = ''; // revision comment / edit summary
- var $mContribution= ''; // number of bytes changed
- var $mContrib= ''; // short string indicating the size of a
contribution
- var $mContributor= ''; // user who made the changes
+ public $mTitle = ''; // title
+ public $mNamespace = -1; // namespace (number)
+ public $mID = 0; // page_id
+ public $mSelTitle = ''; // selected title of initial page
+ public $mSelNamespace = -1;// selected namespace (number) of initial
page
+ public $mImageSelTitle = ''; // selected title of image
+ public $mLink = ''; // html link to page
+ public $mExternalLink = '';// external link on the page
+ public $mStartChar = ''; // page title first char
+ public $mParentHLink = ''; // heading (link to the associated page)
that page belongs to in the list (default '' means no heading)
+ public $mCategoryLinks = array(); // category links in the page
+ public $mCategoryTexts = array(); // category names (without link) in
the page
+ public $mCounter = ''; // Number of times this page has been viewed
+ public $mSize = ''; // Article length in bytes of wiki text
+ public $mDate = ''; // timestamp depending on the user's
request (can be first/last edit, page_touched, ...)
+ public $myDate = ''; // the same, based on user format
definition
+ public $mRevision = ''; // the revision number if specified
+ public $mUserLink = ''; // link to editor (first/last,
depending on user's request) 's page or contributions if not registered
+ public $mUser = ''; // name of editor (first/last,
depending on user's request) or contributions if not registered
+ public $mComment = ''; // revision comment / edit summary
+ public $mContribution= ''; // number of bytes changed
+ public $mContrib= ''; // short string indicating the size of a
contribution
+ public $mContributor= ''; // user who made the changes
function __construct($title, $namespace) {
$this->mTitle = $title;
diff --git a/DPLListMode.php b/DPLListMode.php
index 04544e8..af9ca23 100644
--- a/DPLListMode.php
+++ b/DPLListMode.php
@@ -1,17 +1,17 @@
<?php
class DPLListMode {
- var $name;
- var $sListStart = '';
- var $sListEnd = '';
- var $sHeadingStart = '';
- var $sHeadingEnd = '';
- var $sItemStart = '';
- var $sItemEnd = '';
- var $sInline = '';
- var $sSectionTags = array();
- var $aMultiSecSeparators = array();
- var $iDominantSection = -1;
+ public $name;
+ public $sListStart = '';
+ public $sListEnd = '';
+ public $sHeadingStart = '';
+ public $sHeadingEnd = '';
+ public $sItemStart = '';
+ public $sItemEnd = '';
+ public $sInline = '';
+ public $sSectionTags = array();
+ public $aMultiSecSeparators = array();
+ public $iDominantSection = -1;
function __construct($listmode, $secseparators, $multisecseparators,
$inlinetext, $listattr = '', $itemattr = '',
$listseparators, $iOffset,
$dominantSection) {
diff --git a/DPLLogger.php b/DPLLogger.php
index dc712ad..89c954d 100644
--- a/DPLLogger.php
+++ b/DPLLogger.php
@@ -4,7 +4,7 @@
static $loaded = true;
- var $iDebugLevel;
+ public $iDebugLevel;
function __construct() {
$this->iDebugLevel =
ExtDynamicPageList::$options['debug']['default'];
--
To view, visit https://gerrit.wikimedia.org/r/154601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06f550f3d1cf343934d453b3acebb1f5b6df2019
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicPageList
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
