jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: I84b554884aaa53d11e4992517e6c15bd4cb682a1
---
M VideoClass.php
M VideoGallery.php
M VideoPage.php
3 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VideoClass.php b/VideoClass.php
index 16c9507..b8e6f2c 100644
--- a/VideoClass.php
+++ b/VideoClass.php
@@ -5,68 +5,68 @@
/**
* @var String: database key of the video
*/
- var $name;
+ public $name;
/**
* @var Title: Title object associated with the current Video
*/
- var $title;
+ public $title;
/**
* @var Boolean: does this video exist? True = exists, false = doesn't.
*/
- var $exists;
+ public $exists;
/**
* @var Integer: height of the video, is set to 400 in this class'
* constructor
*/
- var $height;
+ public $height;
/**
* @var Integer: width of the video, is set to 400 in this class'
* constructor
*/
- var $width;
+ public $width;
/**
* @var Integer: is set to 1 in this class' constructor. Provider
classes
* should calculate this by diving width by height.
*/
- var $ratio;
+ public $ratio;
/**
* @var String: URL to the video on the provider service
*/
- var $url;
+ public $url;
/**
* @var String: username of the person who added the current video to
the
* wiki
*/
- var $submitter_user_name;
+ public $submitter_user_name;
/**
* @var Integer: user ID number of the person who added the current
video
* to the wiki
*/
- var $submitter_user_id;
+ public $submitter_user_id;
/**
* @var Integer: timestamp when this video was added to the wiki
*/
- var $create_date;
+ public $create_date;
/**
* @var String: lowercase/internal name of the video provider service,
such
* as 'youtube' or 'archiveorg'
*/
- var $type;
+ public $type;
/**
* @var Boolean: has all the metadata been loaded into the cache?
*/
- var $dataLoaded;
+ public $dataLoaded;
/**
* @var IContextSource
diff --git a/VideoGallery.php b/VideoGallery.php
index 5ceac88..a71c3db 100644
--- a/VideoGallery.php
+++ b/VideoGallery.php
@@ -81,12 +81,12 @@
* Add videos to the gallery using add(), then render that list to HTML using
toHTML().
*/
class VideoGallery {
- var $mVideos, $mShowFilename;
+ public $mVideos, $mShowFilename;
/**
* Is the gallery on a wiki page (i.e. not a special page)
*/
- var $mParsing;
+ public $mParsing;
private $mPerRow = 3; // How many videos wide should the gallery be?
private $mWidths = 200, $mHeights = 200; // How wide/tall each
thumbnail should be
diff --git a/VideoPage.php b/VideoPage.php
index 7e057e4..3e8effd 100644
--- a/VideoPage.php
+++ b/VideoPage.php
@@ -2,7 +2,7 @@
class VideoPage extends Article {
- var $title = null;
+ public $title = null;
/**
* Constructor and clear the article
--
To view, visit https://gerrit.wikimedia.org/r/154691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84b554884aaa53d11e4992517e6c15bd4cb682a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Video
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
