jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: I54f3dbb1c11c525dc973619894bc6a4bb48b3c64
---
M GoogleMaps.body.php
M export/GoogleMapsExporter.php
M export/GoogleMapsImgExporter.php
M export/GoogleMapsJsExporter.php
M export/GoogleMapsKmlExporter.php
5 files changed, 23 insertions(+), 23 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GoogleMaps.body.php b/GoogleMaps.body.php
index 0d8e2c2..fc7949d 100644
--- a/GoogleMaps.body.php
+++ b/GoogleMaps.body.php
@@ -27,50 +27,50 @@
// the Google API key (obtained from
// http://www.google.com/apis/maps/signup.html)
- var $mApiKey = null;
+ public $mApiKey = null;
// if true, paths will be enabled on the maps
- var $mEnablePaths = false;
+ public $mEnablePaths = false;
// the map language message structure
- var $mMessages = null;
+ public $mMessages = null;
// custom messages. these override the values in $mMessages, if present
- var $mCustomMessages = null;
+ public $mCustomMessages = null;
// the MediaWiki language code (used to key messgaes)
- var $mLanguageCode = null;
+ public $mLanguageCode = null;
// a local count of how many maps have been rendered on the
current page
- var $mGoogleMapsOnThisPage = 0;
+ public $mGoogleMapsOnThisPage = 0;
// the mime type to use for javascript
- var $mJsMimeType = null;
+ public $mJsMimeType = null;
// the map default settings
- var $mMapDefaults = null;
+ public $mMapDefaults = null;
// the template variables to process
- var $mProcessTemplateVariables = null;
+ public $mProcessTemplateVariables = null;
// an array of valid values for map settings. The keys are the setting
names
// and the values are arrays of valid values for that setting.
- var $mApprovedValues = null;
+ public $mApprovedValues = null;
// a dictionary of tokens mapped to their end values for
different settings.
// the keys to the array are the setting names, the values are hashes
of
// key/value pairs where the key is the token and the value
is the full
// value.
- var $mOptionDictionary = null;
+ public $mOptionDictionary = null;
// whether the current language is read right-to-left
- var $mLanguage = null;
+ public $mLanguage = null;
// a secret key used in parsing
- var $wgProxyKey = null;
+ public $wgProxyKey = null;
// the current page
- var $mTitle = null;
+ public $mTitle = null;
//----------------------------------------------
// CONSTRUCTOR
diff --git a/export/GoogleMapsExporter.php b/export/GoogleMapsExporter.php
index c16982b..1a92cc8 100644
--- a/export/GoogleMapsExporter.php
+++ b/export/GoogleMapsExporter.php
@@ -1,7 +1,7 @@
<?php
class GoogleMapsExporter {
- var $mOutput;
+ public $mOutput;
function addXmlSource($url) {
}
diff --git a/export/GoogleMapsImgExporter.php b/export/GoogleMapsImgExporter.php
index cc24ee6..44d88f0 100644
--- a/export/GoogleMapsImgExporter.php
+++ b/export/GoogleMapsImgExporter.php
@@ -1,8 +1,8 @@
<?php
class GoogleMapsImgExporter extends GoogleMapsExporter {
- var $mApiKey;
- var $mLanguageCode;
+ public $mApiKey;
+ public $mLanguageCode;
function __construct($pApiKey, $pLanguageCode) {
$this->mApiKey = $pApiKey;
diff --git a/export/GoogleMapsJsExporter.php b/export/GoogleMapsJsExporter.php
index 9d6f6b6..ae718ec 100644
--- a/export/GoogleMapsJsExporter.php
+++ b/export/GoogleMapsJsExporter.php
@@ -1,9 +1,9 @@
<?php
class GoogleMapsJsExporter extends GoogleMapsExporter {
- var $mEnablePaths;
- var $mLanguage;
- var $mProxyKey;
+ public $mEnablePaths;
+ public $mLanguage;
+ public $mProxyKey;
function __construct(&$pLanguage, &$pProxyKey, $pEnablePaths = true) {
$this->mOutput = '';
diff --git a/export/GoogleMapsKmlExporter.php b/export/GoogleMapsKmlExporter.php
index a266ba9..5b18df0 100644
--- a/export/GoogleMapsKmlExporter.php
+++ b/export/GoogleMapsKmlExporter.php
@@ -1,9 +1,9 @@
<?php
class GoogleMapsKmlExporter extends GoogleMapsExporter {
- var $mIcons;
- var $mIcon;
- var $mMarkerCount;
+ public $mIcons;
+ public $mIcon;
+ public $mMarkerCount;
function __construct(&$pLanguage, $pIcon) {
$this->mOutput = '';
--
To view, visit https://gerrit.wikimedia.org/r/154610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54f3dbb1c11c525dc973619894bc6a4bb48b3c64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleMaps
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
