Yurik has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154711
Change subject: Fix no-script image <a> link
......................................................................
Fix no-script image <a> link
Change-Id: Ia12a417944892a1ebc94de4b25063be21002be3a
---
M includes/PageRendering.php
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner
refs/changes/11/154711/1
diff --git a/includes/PageRendering.php b/includes/PageRendering.php
index bea628a..4fc7d5e 100644
--- a/includes/PageRendering.php
+++ b/includes/PageRendering.php
@@ -359,9 +359,11 @@
$urlJsBanner = self::getSpecial()->getLocalURL( $query
);
$script = Html::rawElement( 'script', array( 'src' =>
$urlJsBanner ) );
- $noScript =
- Html::rawElement( 'a', array( 'href',
self::getSpecial()->getLinkURL( 'info=1' ) ),
- Html::rawElement( 'noscript', array(),
self::renderBannerImgTag( $isFilePage ) ) );
+ $noScript = self::renderBannerImgTag( $isFilePage );
+// $noScript =
+// Html::rawElement( 'a', array( 'href' =>
self::getSpecial()->getLinkURL( 'info=1' ) ),
+// $noScript );
+ $noScript = Html::rawElement( 'noscript', array(),
$noScript );
return $script . $noScript;
}
$config = $this->getZeroConfig();
--
To view, visit https://gerrit.wikimedia.org/r/154711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia12a417944892a1ebc94de4b25063be21002be3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Yurik <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
