jenkins-bot has submitted this change and it was merged.
Change subject: Use jquery.spinner module instead of
skins/common/images/spinner.gif
......................................................................
Use jquery.spinner module instead of skins/common/images/spinner.gif
Bug: 69672
Change-Id: If36ddaa241b215770115da1b19a4810e086fc441
---
M ApiSandbox.php
M resources/main.js
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ApiSandbox.php b/ApiSandbox.php
index bcd03c8..c9ffc6e 100644
--- a/ApiSandbox.php
+++ b/ApiSandbox.php
@@ -50,6 +50,7 @@
),
'dependencies' => array(
'mediawiki.util',
+ 'jquery.spinner',
'jquery.ui.button',
)
);
diff --git a/resources/main.js b/resources/main.js
index 4142bcc..458b0a3 100644
--- a/resources/main.js
+++ b/resources/main.js
@@ -63,11 +63,9 @@
* @param $element {jQuery} Container for the loading message
*/
function showLoading( $element ) {
- $element.html(
- mw.html.element( 'img',
- { src: mw.config.get( 'stylepath' ) +
'/common/images/spinner.gif', alt: '' } ) +
- mw.html.escape( mw.msg( 'apisb-loading' ) )
- );
+ $element
+ .text( mw.msg( 'apisb-loading' ) )
+ .prepend( $.createSpinner( { size: 'small', type:
'inline' } ) );
}
function showLoadError( $element, message ) {
--
To view, visit https://gerrit.wikimedia.org/r/154483
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If36ddaa241b215770115da1b19a4810e086fc441
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiSandbox
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
