Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154791
Change subject: Revert "Update translation pages on deleting translation unit"
......................................................................
Revert "Update translation pages on deleting translation unit"
This reverts commit 939459cc3c80b12e3f95f05e4e9ecf6f6b35805f.
Causes PHP Fatal error: Call to undefined method
FileBasedMessageGroup::getTitle() in
/www/translatewiki.net/w/extensions/Translate/tag/PageTranslationHooks.php on
line 929
Change-Id: I94eb2370d3d0f7cb0d472893e0cfeade84d8d3fc
---
M TranslateHooks.php
M tag/PageTranslationHooks.php
M tag/TranslateDeleteJob.php
3 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/91/154791/1
diff --git a/TranslateHooks.php b/TranslateHooks.php
index 28354fb..8e3682f 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -164,9 +164,6 @@
// Update translated page when translation unit is moved
$wgHooks['TitleMoveComplete'][] =
'PageTranslationHooks::onMoveTranslationUnits';
-
- // Update translated page when translation unit is
deleted
- $wgHooks['ArticleDeleteComplete'][] =
'PageTranslationHooks::onDeleteTranslationUnits';
}
}
diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index 1eb9dac..7d1f7cf 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -910,25 +910,4 @@
}
}
}
-
- /**
- * Hook to update translation pages on deleting translation units
- * Hook: ArticleDeleteComplete
- * @since 2014.08
- */
- public static function onDeleteTranslationUnits( WikiPage &$unit, User
&$user, $reason,
- $id, $content, $logEntry
- ) {
- // Do the update. In case job queue is doing the work, the
update is not done here
- if ( !self::$jobQueueRunning ) {
- $title = $unit->getTitle();
- $handle = new MessageHandle( $title );
- if ( $handle->isValid() ) {
- $language = $handle->getCode();
- $group = $handle->getGroup();
- $page = TranslatablePage::newFromTitle(
$group->getTitle() );
- self::updateTranslationPage( $page, $language,
$user, 0, $reason );
- }
- }
- }
}
diff --git a/tag/TranslateDeleteJob.php b/tag/TranslateDeleteJob.php
index 62582a8..177721d 100644
--- a/tag/TranslateDeleteJob.php
+++ b/tag/TranslateDeleteJob.php
@@ -47,7 +47,6 @@
$doer = User::newFromName( $this->getPerformer() );
PageTranslationHooks::$allowTargetEdit = true;
- PageTranslationHooks::$jobQueueRunning = true;
$error = '';
$wikipage = new WikiPage( $title );
@@ -88,7 +87,6 @@
$page->invalidateCache();
}
$title->invalidateCache();
- PageTranslationHooks::$jobQueueRunning = false;
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/154791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94eb2370d3d0f7cb0d472893e0cfeade84d8d3fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
