Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154976
Change subject: metrics: remove broken dependency on Apache site
......................................................................
metrics: remove broken dependency on Apache site
since Id10e7b844ac1 we are using the new apache::site
to setup the Apache site, but that means we write
sites into sites-available and symlink to sites-enabled,
as we should
that breaks this dependency, and i argue that the logfiles
being readable for that group does not even really require
that Apache site to exist.
if you should disagree with the last part, please tell me what it
should depend on now
Change-Id: I38c2c1db4618fd090bfb8670bf314968bc296c03
---
M manifests/misc/statistics.pp
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/76/154976/1
diff --git a/manifests/misc/statistics.pp b/manifests/misc/statistics.pp
index ea0e049..f522f5a 100644
--- a/manifests/misc/statistics.pp
+++ b/manifests/misc/statistics.pp
@@ -405,7 +405,6 @@
# make access and error log for metrics-api readable by wikidev group
file { ['/var/log/apache2/access.metrics.log',
'/var/log/apache2/error.metrics.log']:
group => 'wikidev',
- require => File["/etc/apache2/sites-enabled/${site_name}"],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/154976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c2c1db4618fd090bfb8670bf314968bc296c03
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
