Henning Snater has submitted this change and it was merged.
Change subject: Remove unused dependency from pagesuggester
......................................................................
Remove unused dependency from pagesuggester
This is a follow-up to I44a2240 and later patches in the same
chain. I'm aware some of these changes are a matter of taste.
This patch is mainly meant as a collection of suggestions.
I'm pretty sure about the dependency but it would be good if you
could check this.
Change-Id: I5cca87db5a8e06ffe70697c0d21ada01b1f6c595
---
M lib/resources/Resources.php
M lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
M lib/resources/wikibase.css
3 files changed, 5 insertions(+), 8 deletions(-)
Approvals:
WikidataJenkins: Verified
Henning Snater: Looks good to me, approved
jenkins-bot: Checked
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index f64c76b..2ab5849 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -317,7 +317,6 @@
'jquery.NativeEventHandler',
'jquery.inputautoexpand',
'jquery.tablesorter',
- 'jquery.ui.suggester',
'util.inherit',
'jquery.wikibase.entityselector',
'jquery.wikibase.pagesuggester',
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
b/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
index 13e3e93..7d23e4c 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
@@ -40,8 +40,9 @@
this.element
.on( this.widgetEventPrefix + 'change.' + this.widgetName,
function( event ) {
- if( $.trim( self.element.val() ) !== self.option(
'pageName' ) ) {
- self.option( 'pageName', $.trim(
self.element.val() ) );
+ var value = $.trim( self.element.val() );
+ if( value !== self.option( 'pageName' ) ) {
+ self.option( 'pageName', value );
}
} );
},
@@ -57,7 +58,7 @@
}
if( key === 'pageName' ) {
- this.element.val( this.option( 'pageName' ) );
+ this.element.val( value );
this._trigger( 'change' );
}
},
diff --git a/lib/resources/wikibase.css b/lib/resources/wikibase.css
index 8ba847b..36f7b9e 100644
--- a/lib/resources/wikibase.css
+++ b/lib/resources/wikibase.css
@@ -387,11 +387,8 @@
}
table.wb-terms td {
- border-top: 1px solid #C9C9C9;
-}
-
-table.wb-terms td {
background: #F0F0F0;
+ border-top: 1px solid #C9C9C9;
}
table.wb-terms tr:nth-child(4n) td,
table.wb-terms tr:nth-child(4n-1) td {
--
To view, visit https://gerrit.wikimedia.org/r/154880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cca87db5a8e06ffe70697c0d21ada01b1f6c595
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
