Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Escape message ......................................................................
Escape message mw.msg() should get escaped. Restore jQuery code from before I60a4b702a653d9b4b1d83ae2d83d4bc66ca9830f for creating element. See: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Creating_elements Change-Id: Icecd041dd3c2e28ff89e51d5128c7a15789530f4 Follows-Up: I60a4b702a653d9b4b1d83ae2d83d4bc66ca9830f --- M repo/resources/wikibase.ui.entitysearch.js 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: WikidataJenkins: Verified Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Checked diff --git a/repo/resources/wikibase.ui.entitysearch.js b/repo/resources/wikibase.ui.entitysearch.js index 0950ef6..7e55ade 100644 --- a/repo/resources/wikibase.ui.entitysearch.js +++ b/repo/resources/wikibase.ui.entitysearch.js @@ -77,12 +77,15 @@ $.removeData( input, 'suggestionsContext' ); } - var $searchContaining = $( '' - + '<div class="suggestions-special">' - + '<div class="special-label">' + mw.msg( 'searchsuggest-containing' ) + '</div>' - + '<div class="special-query"></div>' - + '</div>' - ); + var $searchContaining = $( '<div>' ) + .addClass( 'suggestions-special' ) + .append( + $( '<div>' ) + .addClass( 'special-label' ) + .text( mw.msg( 'searchsuggest-containing' ) ), + $( '<div>' ) + .addClass( 'special-query' ) + ); var $searchMenu = $( '<ul/>' ).ooMenu( { customItems: [ -- To view, visit https://gerrit.wikimedia.org/r/154872 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icecd041dd3c2e28ff89e51d5128c7a15789530f4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com> Gerrit-Reviewer: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
