jenkins-bot has submitted this change and it was merged.
Change subject: QA: Extension dependencies for geodata-related scenarios
......................................................................
QA: Extension dependencies for geodata-related scenarios
Change-Id: I0c1e2a300edf84049129a465d1dfaa1a3fce264d
---
M tests/browser/features/geonotahack.feature
M tests/browser/features/mainmenu.feature
M tests/browser/features/mainmenu_loggedin.feature
M tests/browser/features/nearby.feature
M tests/browser/features/no_javascript_site.feature
M tests/browser/features/special.feature
6 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/geonotahack.feature
b/tests/browser/features/geonotahack.feature
index 755a863..7e9e798 100644
--- a/tests/browser/features/geonotahack.feature
+++ b/tests/browser/features/geonotahack.feature
@@ -1,4 +1,4 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @firefox
+@chrome @en.m.wikipedia.beta.wmflabs.org @extension-geodata @firefox
Feature: Nearby pages
Background:
diff --git a/tests/browser/features/mainmenu.feature
b/tests/browser/features/mainmenu.feature
index 034c18d..19c6b02 100644
--- a/tests/browser/features/mainmenu.feature
+++ b/tests/browser/features/mainmenu.feature
@@ -15,6 +15,7 @@
And I see a link to "Watchlist" in the main navigation menu
And I see a link to "Log in" in the main navigation menu
+ @extension-geodata
Scenario: Nearby link in menu
Given at least one article with geodata exists
When I click on the main navigation button
diff --git a/tests/browser/features/mainmenu_loggedin.feature
b/tests/browser/features/mainmenu_loggedin.feature
index be4e991..674c451 100644
--- a/tests/browser/features/mainmenu_loggedin.feature
+++ b/tests/browser/features/mainmenu_loggedin.feature
@@ -17,6 +17,7 @@
And I see a link to "Watchlist" in the main navigation menu
And I see a link to "Uploads" in the main navigation menu
+ @extension-geodata
Scenario: Nearby link in menu
Given at least one article with geodata exists
When I click on the main navigation button
diff --git a/tests/browser/features/nearby.feature
b/tests/browser/features/nearby.feature
index d055433..75149f4 100644
--- a/tests/browser/features/nearby.feature
+++ b/tests/browser/features/nearby.feature
@@ -1,4 +1,4 @@
-@firefox @vagrant
+@extension-geodata @firefox @vagrant
Feature: Nearby page (mobile interface)
Test currently only works with Firefox
diff --git a/tests/browser/features/no_javascript_site.feature
b/tests/browser/features/no_javascript_site.feature
index cb3667e..0f9c0a7 100644
--- a/tests/browser/features/no_javascript_site.feature
+++ b/tests/browser/features/no_javascript_site.feature
@@ -24,7 +24,12 @@
And I see a link to "Watchlist" in the main navigation menu
And I see a link to "Log in" in the main navigation menu
And I do not see a link to "Uploads" in the main navigation menu
- And I do not see a link to "Nearby" in the main navigation menu
+
+ @extension-geodata
+ Scenario: Nearby link not present in main navigation menu
+ When I click on "Random" in the main navigation menu
+ And I click on the main navigation button
+ Then I do not see a link to "Nearby" in the main navigation menu
Scenario: Search with JavaScript disabled
Given the page "Selenium search test" exists
diff --git a/tests/browser/features/special.feature
b/tests/browser/features/special.feature
index 677fde1..2e2a0a9 100644
--- a/tests/browser/features/special.feature
+++ b/tests/browser/features/special.feature
@@ -17,6 +17,7 @@
And I click the placeholder search box
Then I see the search overlay
+ @extension-geodata
Scenario: Search from Nearby
When I click on "Nearby" in the main navigation menu
And I click the placeholder search box
--
To view, visit https://gerrit.wikimedia.org/r/153988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c1e2a300edf84049129a465d1dfaa1a3fce264d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
