jenkins-bot has submitted this change and it was merged.
Change subject: Reinstate the ve-ui-toolbar-saveButton class
......................................................................
Reinstate the ve-ui-toolbar-saveButton class
The class provided a minimal coupling to the firsteditve guided tour,
which used it to attach a guider to the "Save page" button.
The class was removed in I30dc7020121f0dd6907b61ef674a7cb14eb00652.
Bug: 69784
Change-Id: I81fdc4f2fa41c86a6481cf478c154b5d6c99d41d
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index b3b0a8f..b1eeb1b 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1145,6 +1145,10 @@
'disabled': !this.restoring
} );
+ // NOTE (phuedx, 2014-08-20): This class is used by the firsteditve
guided
+ // tour to attach a guider to the "Save page" button.
+ this.toolbarSaveButton.$element.addClass( 've-ui-toolbar-saveButton' );
+
if ( ve.msg( 'accesskey-save' ) !== '-' && ve.msg( 'accesskey-save' )
!== '' ) {
// FlaggedRevs tries to use this - it's useless on VE pages
because all that stuff gets hidden, but it will still conflict so get rid of it
this.elementsThatHadOurAccessKey = $( '[accesskey="' + ve.msg(
'accesskey-save' ) + '"]' ).removeAttr( 'accesskey' );
--
To view, visit https://gerrit.wikimedia.org/r/155280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81fdc4f2fa41c86a6481cf478c154b5d6c99d41d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
