jenkins-bot has submitted this change and it was merged.
Change subject: Split RevisionDeleteAbstracts.php to separate files
......................................................................
Split RevisionDeleteAbstracts.php to separate files
Same as I244a66fe19c089df4bcabcf745536d99b2103bc4
Change-Id: I90cea070a8e24d82f0675f122c79326988351e08
---
M includes/AutoLoader.php
A includes/revisiondelete/RevDelItem.php
R includes/revisiondelete/RevDelList.php
3 files changed, 64 insertions(+), 46 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/AutoLoader.php b/includes/AutoLoader.php
index f7f4c59..38e92b6 100644
--- a/includes/AutoLoader.php
+++ b/includes/AutoLoader.php
@@ -893,8 +893,8 @@
'RevDelArchiveList' => 'includes/revisiondelete/RevDelArchiveList.php',
'RevDelFileItem' => 'includes/revisiondelete/RevDelFileItem.php',
'RevDelFileList' => 'includes/revisiondelete/RevDelFileList.php',
- 'RevDelItem' => 'includes/revisiondelete/RevisionDeleteAbstracts.php',
- 'RevDelList' => 'includes/revisiondelete/RevisionDeleteAbstracts.php',
+ 'RevDelItem' => 'includes/revisiondelete/RevDelItem.php',
+ 'RevDelList' => 'includes/revisiondelete/RevDelList.php',
'RevDelLogItem' => 'includes/revisiondelete/RevDelLogItem.php',
'RevDelLogList' => 'includes/revisiondelete/RevDelLogList.php',
'RevDelRevisionItem' =>
'includes/revisiondelete/RevDelRevisionItem.php',
diff --git a/includes/revisiondelete/RevDelItem.php
b/includes/revisiondelete/RevDelItem.php
new file mode 100644
index 0000000..ebdbf3a
--- /dev/null
+++ b/includes/revisiondelete/RevDelItem.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ * @ingroup RevisionDelete
+ */
+
+/**
+ * Abstract base class for deletable items
+ */
+abstract class RevDelItem extends RevisionItemBase {
+ /**
+ * Returns true if the item is "current", and the operation to set the
given
+ * bits can't be executed for that reason
+ * STUB
+ * @param int $newBits
+ * @return bool
+ */
+ public function isHideCurrentOp( $newBits ) {
+ return false;
+ }
+
+ /**
+ * Get the current deletion bitfield value
+ */
+ abstract public function getBits();
+
+ /**
+ * Set the visibility of the item. This should do any necessary DB
queries.
+ *
+ * The DB update query should have a condition which forces it to only
update
+ * if the value in the DB matches the value fetched earlier with the
SELECT.
+ * If the update fails because it did not match, the function should
return
+ * false. This prevents concurrency problems.
+ *
+ * @param int $newBits
+ * @return bool Success
+ */
+ abstract public function setBits( $newBits );
+
+ /**
+ * Get the return information about the revision for the API
+ * @since 1.23
+ * @param ApiResult $result API result object
+ * @return array Data for the API result
+ */
+ abstract public function getApiData( ApiResult $result );
+}
diff --git a/includes/revisiondelete/RevisionDeleteAbstracts.php
b/includes/revisiondelete/RevDelList.php
similarity index 88%
rename from includes/revisiondelete/RevisionDeleteAbstracts.php
rename to includes/revisiondelete/RevDelList.php
index e92a533..a0ff667 100644
--- a/includes/revisiondelete/RevisionDeleteAbstracts.php
+++ b/includes/revisiondelete/RevDelList.php
@@ -1,7 +1,5 @@
<?php
/**
- * Interface definition for deletable items.
- *
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
@@ -312,46 +310,4 @@
* Get the integer value of the flag used for suppression
*/
abstract public function getSuppressBit();
-}
-
-/**
- * Abstract base class for deletable items
- */
-abstract class RevDelItem extends RevisionItemBase {
- /**
- * Returns true if the item is "current", and the operation to set the
given
- * bits can't be executed for that reason
- * STUB
- * @param int $newBits
- * @return bool
- */
- public function isHideCurrentOp( $newBits ) {
- return false;
- }
-
- /**
- * Get the current deletion bitfield value
- */
- abstract public function getBits();
-
- /**
- * Set the visibility of the item. This should do any necessary DB
queries.
- *
- * The DB update query should have a condition which forces it to only
update
- * if the value in the DB matches the value fetched earlier with the
SELECT.
- * If the update fails because it did not match, the function should
return
- * false. This prevents concurrency problems.
- *
- * @param int $newBits
- * @return bool Success
- */
- abstract public function setBits( $newBits );
-
- /**
- * Get the return information about the revision for the API
- * @since 1.23
- * @param ApiResult $result API result object
- * @return array Data for the API result
- */
- abstract public function getApiData( ApiResult $result );
}
--
To view, visit https://gerrit.wikimedia.org/r/152912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90cea070a8e24d82f0675f122c79326988351e08
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
