[MediaWiki-commits] [Gerrit] Use public instead of var in classes - change (mediawiki...CentralNotice)

[Awight (Code Review)]

Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/155321

Change subject: Use public instead of var in classes
......................................................................

Use public instead of var in classes

Change-Id: If1a3d18d28d7065bf3a164863d46d964c6192c07
---
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
M CentralNoticePageLogPager.php
M CentralNoticePager.php
M TemplatePager.php
M special/SpecialCentralNotice.php
M special/SpecialNoticeTemplate.php
M tests/CentralNoticeTest.php
8 files changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/21/155321/1

diff --git a/CentralNoticeBannerLogPager.php b/CentralNoticeBannerLogPager.php
index 6488377..2362b7c 100644
--- a/CentralNoticeBannerLogPager.php
+++ b/CentralNoticeBannerLogPager.php
@@ -1,7 +1,7 @@
 <?php
 
 class CentralNoticeBannerLogPager extends CentralNoticeCampaignLogPager {
-       var $special;
+       public $special;
 
        function __construct( $special ) {
                $this->special = $special;
diff --git a/CentralNoticeCampaignLogPager.php 
b/CentralNoticeCampaignLogPager.php
index 31bf2f9..d19cafb 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -1,7 +1,7 @@
 <?php
 
 class CentralNoticeCampaignLogPager extends ReverseChronologicalPager {
-       var $viewPage, $special;
+       public $viewPage, $special;
 
        function __construct( $special ) {
                $this->special = $special;
diff --git a/CentralNoticePageLogPager.php b/CentralNoticePageLogPager.php
index 7d709d1..46ca21d 100644
--- a/CentralNoticePageLogPager.php
+++ b/CentralNoticePageLogPager.php
@@ -6,7 +6,7 @@
  * the log only goes back 30 days.
  */
 class CentralNoticePageLogPager extends ReverseChronologicalPager {
-       var $viewPage, $special, $logType;
+       public $viewPage, $special, $logType;
 
        /**
         * Construct instance of class.
diff --git a/CentralNoticePager.php b/CentralNoticePager.php
index a32ef26..71c741d 100644
--- a/CentralNoticePager.php
+++ b/CentralNoticePager.php
@@ -1,9 +1,9 @@
 <?php
 
 class CentralNoticePager extends TemplatePager {
-       var $viewPage, $special;
-       var $editable;
-       var $filter;
+       public $viewPage, $special;
+       public $editable;
+       public $filter;
 
        function __construct( $special, $filter = '' ) {
                parent::__construct( $special, $filter );
diff --git a/TemplatePager.php b/TemplatePager.php
index 01a3510..c612f3b 100644
--- a/TemplatePager.php
+++ b/TemplatePager.php
@@ -8,9 +8,9 @@
  * that part of CN.
  */
 class TemplatePager extends ReverseChronologicalPager {
-       var $onRemoveChange, $viewPage, $special;
-       var $editable;
-       var $filter;
+       public $onRemoveChange, $viewPage, $special;
+       public $editable;
+       public $filter;
 
        function __construct( $special, $filter = '' ) {
                $this->special = $special;
diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index 6eea3b3..ee89630 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -6,7 +6,7 @@
        const HIGH_PRIORITY = 2;
        const EMERGENCY_PRIORITY = 3;
 
-       var $editable, $centralNoticeError;
+       public $editable, $centralNoticeError;
 
        function __construct() {
                // Register special page
diff --git a/special/SpecialNoticeTemplate.php 
b/special/SpecialNoticeTemplate.php
index b9b6595..98f8d2e 100644
--- a/special/SpecialNoticeTemplate.php
+++ b/special/SpecialNoticeTemplate.php
@@ -1,7 +1,7 @@
 <?php
 
 class SpecialNoticeTemplate extends CentralNotice {
-       var $editable, $centralNoticeError;
+       public $editable, $centralNoticeError;
 
        function __construct() {
                // Register special page
diff --git a/tests/CentralNoticeTest.php b/tests/CentralNoticeTest.php
index 155a502..7af0a94 100644
--- a/tests/CentralNoticeTest.php
+++ b/tests/CentralNoticeTest.php
@@ -19,7 +19,7 @@
 
        protected $campaignArray;
 
-       var $campaignId;
+       public $campaignId;
 
        protected function setUp() {
                parent::setUp();

-- 
To view, visit https://gerrit.wikimedia.org/r/155321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1a3d18d28d7065bf3a164863d46d964c6192c07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: wmf_deploy
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits