jenkins-bot has submitted this change and it was merged.
Change subject: Fix embeddable desktop context popups
......................................................................
Fix embeddable desktop context popups
Use the purpose-built isFocusable instead of instanceof
because FocusableNode is a mixin.
Change-Id: I48fab7253cad58f21ac334424f4d11d6ef19428a
---
M src/ui/ve.ui.DesktopContext.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.DesktopContext.js b/src/ui/ve.ui.DesktopContext.js
index f5f260b..d9e7874 100644
--- a/src/ui/ve.ui.DesktopContext.js
+++ b/src/ui/ve.ui.DesktopContext.js
@@ -133,7 +133,7 @@
var dim,
node = this.surface.getView().getFocusedNode();
- if ( node instanceof ve.ce.FocusableNode ) {
+ if ( node && node.isFocusable() ) {
dim = node.getDimensions();
return (
// HACK: `5` and `10` are estimates of what `0.25em`
and `0.5em` (the margins of the
--
To view, visit https://gerrit.wikimedia.org/r/155617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48fab7253cad58f21ac334424f4d11d6ef19428a
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
