jenkins-bot has submitted this change and it was merged.
Change subject: Remove span-wrapping of link='' images
......................................................................
Remove span-wrapping of link='' images
This hack is no longer neccessary now that we no longer
use shields.
Change-Id: I2194b16273b1ebe6e8d9360957cc7eab856dae13
---
M modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
index fc5af5b..ab91e56 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
@@ -25,11 +25,7 @@
this.$element = this.$( '<a>' ).addClass( 'image' );
this.$image = this.$( '<img>' ).appendTo( this.$element );
} else {
- // For inline images that are not linked (empty linkto=) we
intentionally don't match output
- // of MW Parser, instead we wrap those images in span so
selection and hover (based on
- // shields) can work well. It might change in the future when
we improve our selection.
- this.$element = this.$( '<span>' );
- this.$image = this.$( '<img>' ).appendTo( this.$element );
+ this.$element = this.$image = this.$( '<img>' ).appendTo(
this.$element );
}
// Mixin constructors
--
To view, visit https://gerrit.wikimedia.org/r/154415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2194b16273b1ebe6e8d9360957cc7eab856dae13
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
