Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155633
Change subject: Change comment to meta in whitespace test case to actually test
whitespace handling
......................................................................
Change comment to meta in whitespace test case to actually test whitespace
handling
The point of this test case isn't to test comments, it's to
verify that the "newline bunny-hop bug" is fixed: whitespace
after metadata inside a wrapper isn't moved to before the meta.
This bug was fixed in I4375f4c07.
Change-Id: Ibdb748d46295da09c2fb8a2f6c6c41df7e3fa407
---
M tests/dm/ve.dm.example.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/33/155633/1
diff --git a/tests/dm/ve.dm.example.js b/tests/dm/ve.dm.example.js
index 01df682..8200da8 100644
--- a/tests/dm/ve.dm.example.js
+++ b/tests/dm/ve.dm.example.js
@@ -2341,7 +2341,7 @@
]
},
'whitespace surrounding metadata in a wrapper': {
- body: '<b>Foo</b> <!-- comment -->\n<i>Bar</i>',
+ body: '<b>Foo</b> <meta />\n<i>Bar</i>',
data: [
{ type: 'paragraph', internal: { generated: 'wrapper' }
},
[ 'F', [ ve.dm.example.bold ] ],
@@ -2349,12 +2349,12 @@
[ 'o', [ ve.dm.example.bold ] ],
' ',
{
- type: 'comment',
+ type: 'alienMeta',
attributes: {
- text: ' comment '
+ domElements: $( '<meta />' ).toArray()
}
},
- { type: '/comment' },
+ { type: '/alienMeta' },
'\n',
[ 'B', [ ve.dm.example.italic ] ],
[ 'a', [ ve.dm.example.italic ] ],
--
To view, visit https://gerrit.wikimedia.org/r/155633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdb748d46295da09c2fb8a2f6c6c41df7e3fa407
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
