BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/155687

Change subject: Do not define MEDIAWIKI before loading WebStart.php
......................................................................

Do not define MEDIAWIKI before loading WebStart.php

Defining MEDIAWIKI before loading WebStart.php can lead to warning
messages like "Notice: Constant MEDIAWIKI already defined" and is
unnecessary for the MWVersion calls that proceed loading WebStart.php.

Change-Id: I338d72a47ddb754806209db8a7ba93bcdcc7a16c
---
M w/favicon.php
M w/robots.php
M w/touch.php
3 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/87/155687/1

diff --git a/w/favicon.php b/w/favicon.php
index 00acee5..51641f5 100644
--- a/w/favicon.php
+++ b/w/favicon.php
@@ -1,6 +1,4 @@
 <?php
-define( "MEDIAWIKI", true );
-
 require( "/usr/local/apache/common/w/MWVersion.php" );
 require( getMediaWiki( "includes/WebStart.php" ) );
 
diff --git a/w/robots.php b/w/robots.php
index ebbf68d..60ac511 100644
--- a/w/robots.php
+++ b/w/robots.php
@@ -1,6 +1,4 @@
 <?php
-define( "MEDIAWIKI", true );
-
 require_once( './MWVersion.php' );
 require getMediaWiki( 'includes/WebStart.php' );
 
diff --git a/w/touch.php b/w/touch.php
index 366b7a7..e512fae 100644
--- a/w/touch.php
+++ b/w/touch.php
@@ -1,6 +1,4 @@
 <?php
-define( "MEDIAWIKI", true );
-
 require( "/usr/local/apache/common/w/MWVersion.php" );
 require( getMediaWiki( "includes/WebStart.php" ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/155687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I338d72a47ddb754806209db8a7ba93bcdcc7a16c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to