Tobias Gritschacher has submitted this change and it was merged.
Change subject: protected -> private in JsonDumpGenerator
......................................................................
protected -> private in JsonDumpGenerator
Change-Id: I385b8739c3dffb73d93f71710cf34cf113561516
---
M repo/includes/Dumpers/JsonDumpGenerator.php
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
WikidataJenkins: Verified
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Checked
diff --git a/repo/includes/Dumpers/JsonDumpGenerator.php
b/repo/includes/Dumpers/JsonDumpGenerator.php
index 0843a58..30f0d3f 100644
--- a/repo/includes/Dumpers/JsonDumpGenerator.php
+++ b/repo/includes/Dumpers/JsonDumpGenerator.php
@@ -39,27 +39,27 @@
/**
* @var resource File handle for output
*/
- protected $out;
+ private $out;
/**
* @var Serializer
*/
- protected $entitySerializer;
+ private $entitySerializer;
/**
* @var EntityLookup
*/
- protected $entityLookup;
+ private $entityLookup;
/**
* @var int Total number of shards a request should be split into
*/
- protected $shardingFactor = 1;
+ private $shardingFactor = 1;
/**
* @var int Number of the requested shard
*/
- protected $shard = 0;
+ private $shard = 0;
/**
* @var bool
@@ -69,17 +69,17 @@
/**
* @var string|null
*/
- protected $entityType = null;
+ private $entityType = null;
/**
* @var MessageReporter
*/
- protected $progressReporter;
+ private $progressReporter;
/**
* @var ExceptionHandler
*/
- protected $exceptionHandler;
+ private $exceptionHandler;
/**
* @param resource $out
@@ -229,7 +229,7 @@
* @param EntityId[] $entityIds
* @param int &$dumpCount The number of entities already dumped (will
be updated).
*/
- protected function dumpEntities( array $entityIds, &$dumpCount ) {
+ private function dumpEntities( array $entityIds, &$dumpCount ) {
foreach ( $entityIds as $entityId ) {
if ( !$this->idMatchesFilters( $entityId ) ) {
continue;
--
To view, visit https://gerrit.wikimedia.org/r/155521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I385b8739c3dffb73d93f71710cf34cf113561516
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
