Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155809
Change subject: Change css rule order
......................................................................
Change css rule order
:invalid is incorrectly overriding a :focus:invalid element
correct the order and add a note about this.
Change-Id: I4ee1a4634840b2251e294dfb704c1f5e3b730f7d
---
M resources/src/mediawiki.ui/components/inputs.less
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/09/155809/1
diff --git a/resources/src/mediawiki.ui/components/inputs.less
b/resources/src/mediawiki.ui/components/inputs.less
index 0a50e10..acf1157 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -56,18 +56,19 @@
.field-placeholder-styling;
}
+ // Remove red outline from inputs which have required field and invalid
content.
+ // This is a Firefox only issue
+ // See https://developer.mozilla.org/en-US/docs/Web/CSS/:invalid
+ // This should be above :focus so focus behaviour takes preference
+ &:invalid {
+ box-shadow: none;
+ }
+
&:focus {
box-shadow: inset .45em 0 0 #5088f7;
border-color: @colorGrayDark;
// Remove focus glow on input[type="search"]
outline: 0;
- }
-
- // Remove red outline from inputs which have required field and invalid
content.
- // This is a Firefox only issue
- // See https://developer.mozilla.org/en-US/docs/Web/CSS/:invalid
- &:invalid {
- box-shadow: none;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/155809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ee1a4634840b2251e294dfb704c1f5e3b730f7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
