jenkins-bot has submitted this change and it was merged.
Change subject: Don't apply a background to language annotations in IE
......................................................................
Don't apply a background to language annotations in IE
Because doing that makes the text disappear if dir="rtl" is also set.
Bonus: explain why we're changing which nodes to set highlight
opacities on for IE.
Change-Id: I061e372b26a7b523fc1f307ad9897b884803fdf4
---
M modules/ve-mw/init/styles/ve.init.mw.IEHacks.css
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/styles/ve.init.mw.IEHacks.css
b/modules/ve-mw/init/styles/ve.init.mw.IEHacks.css
index baf3a4a..e7b3e3d 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.IEHacks.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.IEHacks.css
@@ -13,11 +13,18 @@
overflow: visible;
}
-/* Set opacity directly on the highlights, rather than their containers */
+/* Set opacity directly on the highlights, rather than their containers,
+ otherwise the opacity isn't applied at all */
.ve-ce-surface-highlights-focused .ve-ce-focusableNode-highlight {
opacity: 0.5;
}
.ve-ce-surface-highlights-blurred .ve-ce-focusableNode-highlight {
opacity: 0.15;
-}
\ No newline at end of file
+}
+
+/* Don't apply a background color to language annotations, otherwise the
+ text disappears if the span has dir="rtl" */
+.ve-ce-LanguageAnnotation {
+ background: none;
+}
--
To view, visit https://gerrit.wikimedia.org/r/155810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I061e372b26a7b523fc1f307ad9897b884803fdf4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
