Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/155891
Change subject: Be consistent about 'TablePager' CSS class usage ...................................................................... Be consistent about 'TablePager' CSS class usage * Do not use it when not actually using the TablePager * Always use it when actually using the TablePager * Use parent::getTableClass() rather than hardcoding it every time * Place it before other classes to allow overriding Change-Id: I042b65be64e2c2fa6c68a7bb972a7a2ea7f55b4e --- M includes/specials/SpecialAllMessages.php M includes/specials/SpecialBlockList.php M includes/specials/SpecialListfiles.php M includes/specials/SpecialProtectedpages.php M includes/specials/SpecialTrackingCategories.php 5 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/91/155891/1 diff --git a/includes/specials/SpecialAllMessages.php b/includes/specials/SpecialAllMessages.php index 1e4e18b..7096fde 100644 --- a/includes/specials/SpecialAllMessages.php +++ b/includes/specials/SpecialAllMessages.php @@ -336,8 +336,9 @@ } function getStartBody() { + $tableClass = $this->getTableClass(); return Xml::openElement( 'table', array( - 'class' => 'mw-datatable TablePager', + 'class' => "mw-datatable $tableClass", 'id' => 'mw-allmessagestable' ) ) . "\n" . diff --git a/includes/specials/SpecialBlockList.php b/includes/specials/SpecialBlockList.php index 62fadb5..e2ebdbe 100644 --- a/includes/specials/SpecialBlockList.php +++ b/includes/specials/SpecialBlockList.php @@ -409,7 +409,7 @@ } public function getTableClass() { - return 'TablePager mw-blocklist'; + return parent::getTableClass() . ' mw-blocklist'; } function getIndexField() { diff --git a/includes/specials/SpecialListfiles.php b/includes/specials/SpecialListfiles.php index ed7648d..5eafd66 100644 --- a/includes/specials/SpecialListfiles.php +++ b/includes/specials/SpecialListfiles.php @@ -557,15 +557,15 @@ } function getTableClass() { - return 'listfiles ' . parent::getTableClass(); + return parent::getTableClass() . ' listfiles'; } function getNavClass() { - return 'listfiles_nav ' . parent::getNavClass(); + return parent::getNavClass() . ' listfiles_nav'; } function getSortHeaderClass() { - return 'listfiles_sort ' . parent::getSortHeaderClass(); + return parent::getSortHeaderClass() . ' listfiles_sort'; } function getPagingQueries() { diff --git a/includes/specials/SpecialProtectedpages.php b/includes/specials/SpecialProtectedpages.php index b64b029..5072e76 100644 --- a/includes/specials/SpecialProtectedpages.php +++ b/includes/specials/SpecialProtectedpages.php @@ -558,7 +558,7 @@ } public function getTableClass() { - return 'TablePager mw-protectedpages'; + return parent::getTableClass() . ' mw-protectedpages'; } function getIndexField() { diff --git a/includes/specials/SpecialTrackingCategories.php b/includes/specials/SpecialTrackingCategories.php index 5e5588c..552031f 100644 --- a/includes/specials/SpecialTrackingCategories.php +++ b/includes/specials/SpecialTrackingCategories.php @@ -41,7 +41,7 @@ $this->outputHeader(); $this->getOutput()->allowClickjacking(); $this->getOutput()->addHTML( - Html::openElement( 'table', array( 'class' => 'mw-datatable TablePager', + Html::openElement( 'table', array( 'class' => 'mw-datatable', 'id' => 'mw-trackingcategories-table' ) ) . "\n" . "<thead><tr> <th>" . -- To view, visit https://gerrit.wikimedia.org/r/155891 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I042b65be64e2c2fa6c68a7bb972a7a2ea7f55b4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits