Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156027
Change subject: Remove wrong @return from doc blocks
......................................................................
Remove wrong @return from doc blocks
These functions actually does not return anything, so the @return is
wrong here. '@return void' is ignored.
Change-Id: I11495ee05b943c16c1c4715d617c8b50de22276c
---
M includes/Block.php
M includes/EditPage.php
M includes/Import.php
M includes/db/DatabaseMysqlBase.php
M includes/debug/MWDebug.php
M includes/specials/SpecialNewpages.php
M maintenance/checkSyntax.php
7 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/27/156027/1
diff --git a/includes/Block.php b/includes/Block.php
index 88534c0..6a29a05 100644
--- a/includes/Block.php
+++ b/includes/Block.php
@@ -596,7 +596,6 @@
*
* @param Block $block
* @param array &$blockIds
- * @return array Block IDs of retroactive autoblocks made
*/
protected static function defaultRetroactiveAutoblock( Block $block,
array &$blockIds ) {
global $wgPutIPinRC;
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 70eb909..4f2ce5a 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -2758,7 +2758,6 @@
* up top, or false if this is the comment summary
* down below the textarea
* @param string $summary The text of the summary to display
- * @return string
*/
protected function showSummaryInput( $isSubjectPreview, $summary = "" )
{
global $wgOut, $wgContLang;
diff --git a/includes/Import.php b/includes/Import.php
index 3880e25..b3ca041 100644
--- a/includes/Import.php
+++ b/includes/Import.php
@@ -1494,9 +1494,6 @@
return true;
}
- /**
- * @return mixed
- */
function importLogItem() {
$dbw = wfGetDB( DB_MASTER );
# @todo FIXME: This will not record autoblocks
diff --git a/includes/db/DatabaseMysqlBase.php
b/includes/db/DatabaseMysqlBase.php
index 5ad7c78..ba0f39f 100644
--- a/includes/db/DatabaseMysqlBase.php
+++ b/includes/db/DatabaseMysqlBase.php
@@ -901,7 +901,6 @@
/**
* @param bool $value
- * @return null|bool|ResultWrapper
*/
public function setBigSelects( $value = true ) {
if ( $value === 'default' ) {
diff --git a/includes/debug/MWDebug.php b/includes/debug/MWDebug.php
index 0cea658..01e0ba0 100644
--- a/includes/debug/MWDebug.php
+++ b/includes/debug/MWDebug.php
@@ -182,7 +182,6 @@
* @param int $callerOffset How far up the callstack is the original
* caller. 2 = function that called the function that called
* MWDebug::deprecated() (Added in 1.20).
- * @return mixed
*/
public static function deprecated( $function, $version = false,
$component = false, $callerOffset = 2
diff --git a/includes/specials/SpecialNewpages.php
b/includes/specials/SpecialNewpages.php
index fbb2d73..0b70bb7 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -117,7 +117,6 @@
* Show a form for filtering namespace and username
*
* @param string $par
- * @return string
*/
public function execute( $par ) {
$out = $this->getOutput();
diff --git a/maintenance/checkSyntax.php b/maintenance/checkSyntax.php
index 6ef4909..d1c2edd 100644
--- a/maintenance/checkSyntax.php
+++ b/maintenance/checkSyntax.php
@@ -345,7 +345,6 @@
* or pointless ?> closing tags at the end.
*
* @param string $file String Path to a file to check for errors
- * @return bool
*/
private function checkForMistakes( $file ) {
foreach ( $this->mNoStyleCheckPaths as $regex ) {
--
To view, visit https://gerrit.wikimedia.org/r/156027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11495ee05b943c16c1c4715d617c8b50de22276c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
