Jarry1250 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156061
Change subject: Migrate more instances of confusing term "overrides"
......................................................................
Migrate more instances of confusing term "overrides"
...to more sensible term "in-progress translations".
Change-Id: I8f05f90d72a95baf7642958f322e638438143b80
---
M TranslateSvgHooks.php
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg
refs/changes/61/156061/1
diff --git a/TranslateSvgHooks.php b/TranslateSvgHooks.php
index e585a1b..8b17586 100644
--- a/TranslateSvgHooks.php
+++ b/TranslateSvgHooks.php
@@ -322,19 +322,19 @@
$language = isset( $params['language'] ) ?
$params['language'] : $g->getSourceLanguage();
- $overrides = array();
- if ( isset( $params['overrides'] ) ) {
- $overrides = json_decode( $params['overrides'],
true );
+ $inProgressTranslations = array();
+ if ( isset( $params['inprogress'] ) ) {
+ $inProgressTranslations = json_decode(
$params['inprogress'], true );
}
- $writer = new SVGFormatWriter( $g, $overrides );
+ $writer = new SVGFormatWriter( $g,
$inProgressTranslations );
$a['thumbnail'] = $writer->thumbnailExport( $language );
}
return true;
}
/**
- * Define mgoverrides and mglanguage parameters for use with
+ * Define mginprogress and mglanguage parameters for use with
* action=query&meta=messagegroups API queries.
* Used with the TranslateGetAPIMessageGroupsParameterList hook
*
@@ -342,7 +342,7 @@
* @return bool True
*/
public static function addAPIParams( &$params ) {
- $params['overrides'] = array(
+ $params['inprogress'] = array(
ApiBase::PARAM_TYPE => 'string'
);
$params['language'] = array(
@@ -352,7 +352,7 @@
}
/**
- * Document the mgoverrides and mglanguage parameters
+ * Document the mginprogress and mglanguage parameters
* Used with the TranslateGetAPIMessageGroupsParameterDescs hook
*
* @param array $paramDescs An associative array of parameters, name =>
description.
@@ -360,9 +360,9 @@
* @return bool True
*/
public static function addAPIParamDescs( &$paramDescs, $p ) {
- $paramDescs['overrides'] =
- 'Possible array of overriddes (unsaved translations
that should take preference'
- . ' over saved ones). SVG message groups only.';
+ $paramDescs['inprogress'] =
+ 'Possible array of in-progress translations (unsaved
translations that should'
+ . ' take preference over saved ones). SVG message
groups only.';
$paramDescs['language'] =
'Language to render the thumbnail in. SVG message
groups only.';
return true;
--
To view, visit https://gerrit.wikimedia.org/r/156061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f05f90d72a95baf7642958f322e638438143b80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslateSvg
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 <jarry1...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
