jenkins-bot has submitted this change and it was merged.
Change subject: Don't trigger focus event on contenteditable in VE
......................................................................
Don't trigger focus event on contenteditable in VE
This doesn't seem to work anymore, the first focus event doesn't fire
anyway, but that is probably caused by VE bug 68832.
Bug: 68832
Change-Id: Iae25a757c95c89483030d626f4610587ad358d62
---
M javascripts/modules/editor/VisualEditorOverlay.js
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 6e838fd..d1d3efa 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -149,7 +149,6 @@
this.destroyTarget();
},
onSurfaceReady: function () {
- var self = this;
this.clearSpinner();
this.$( '.surface' ).show();
this.target.surface.getModel().getDocument().connect(
this, { 'transact': 'onTransact' } );
@@ -158,11 +157,6 @@
// we have to do it here because contenteditable
elements still do not
// exist when postRender is executed
this._fixIosHeader( '[contenteditable]' );
- // for some reason the first time contenteditables are
focused, focus
- // event doesn't fire if we don't do this (at least on
iOS Safari 7)
- setTimeout( function() {
- self.$( '[contenteditable]' ).focus();
- }, 0 );
},
onTransact: function () {
this.hasChanged = true;
--
To view, visit https://gerrit.wikimedia.org/r/155671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae25a757c95c89483030d626f4610587ad358d62
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
