IAlex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/156688

Change subject: Use as strict comparison to check whether an user name was 
provided in Special:ListFiles
......................................................................

Use as strict comparison to check whether an user name was provided in 
Special:ListFiles

Otherwise Special:ListFiles/0 will not behave as expected.

Change-Id: I1fa503b4b514a471ded798b54e867435d30b80c5
---
M includes/specials/SpecialListfiles.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/156688/1

diff --git a/includes/specials/SpecialListfiles.php 
b/includes/specials/SpecialListfiles.php
index cea6ff8..bd26807 100644
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -89,7 +89,7 @@
                $this->mIncluding = $including;
                $this->mShowAll = $showAll;
 
-               if ( $userName ) {
+               if ( $userName !== null && $userName !== '' ) {
                        $nt = Title::newFromText( $userName, NS_USER );
                        if ( !is_null( $nt ) ) {
                                $this->mUserName = $nt->getText();

-- 
To view, visit https://gerrit.wikimedia.org/r/156688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fa503b4b514a471ded798b54e867435d30b80c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to