jenkins-bot has submitted this change and it was merged. Change subject: QA: Fixed "Upload image file" scenario ......................................................................
QA: Fixed "Upload image file" scenario Fixed issue with early element center calculation during the CSS transition in Chrome by waiting until navigation links are fully visible. (The Chrome webdriver always clicks the center of an element and may fail to calculate the right coordinates during animations.) Change-Id: I2c22e872a8772090d0f508f6c7fa6df78b891a50 --- M tests/browser/features/step_definitions/mainmenu_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/mainmenu_steps.rb b/tests/browser/features/step_definitions/mainmenu_steps.rb index dbc926f..141830d 100644 --- a/tests/browser/features/step_definitions/mainmenu_steps.rb +++ b/tests/browser/features/step_definitions/mainmenu_steps.rb @@ -4,7 +4,7 @@ When(/^I click on "(.*?)" in the main navigation menu$/) do |text| step 'I click on the main navigation button' - on(ArticlePage).navigation_element.link_element(text: text).click + on(ArticlePage).navigation_element.link_element(text: text).when_visible.click end Then(/^I see a link to "(.*?)" in the main navigation menu$/) do |text| -- To view, visit https://gerrit.wikimedia.org/r/155781 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c22e872a8772090d0f508f6c7fa6df78b891a50 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Dduvall <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
