jenkins-bot has submitted this change and it was merged.

Change subject: Workaround flake8 2.2.3 breaking with pep257
......................................................................


Workaround flake8 2.2.3 breaking with pep257

pep257 yields some error which apparently cause flake8 2.2.3 to stall
completely waiting for some input.  That can be worked around by
disabling multiprocessing (turned on by default with 2.2.3). Simply pass
--jobs=1 to flake8 in the flake8-docstrings job.

Upstream issue:
https://bitbucket.org/tarek/flake8/issue/167/flake8-223-stall-with-multiprocessing

Change-Id: Iff84c926b42846b4c36db30507851859a827e103
---
M tox.ini
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tox.ini b/tox.ini
index 9fae601..00fcf0d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,8 +14,15 @@
 deps = flake8
 
 [testenv:flake8-docstrings]
-commands = flake8 --select=D {posargs}
+commands = flake8 --select=D {posargs} --jobs=1
 deps = flake8-docstrings
+# Note: flake8 is run here with --jobs=1 to disable multiprocessing which stall
+# the run with flake8-docstrings / pep257.
+# That appeared with flake8 2.2.3 which turns multiprocessing on by default.
+#
+# See upstream issue:
+# 
https://bitbucket.org/tarek/flake8/issue/167/flake8-223-stall-with-multiprocessing
+
 
 [testenv:nose]
 setenv = PYWIKIBOT2_NO_USER_CONFIG=1

-- 
To view, visit https://gerrit.wikimedia.org/r/157291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff84c926b42846b4c36db30507851859a827e103
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: XZise <commodorefabia...@gmx.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to