[MediaWiki-commits] [Gerrit] Slight speedup for W menu. - change (apps...wikipedia)

[Mhurd (Code Review)]

Mhurd has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/157492

Change subject: Slight speedup for W menu.
......................................................................

Slight speedup for W menu.

Change-Id: I82d5f0d441bbe679a022deab592d5691fde03314
---
M wikipedia/View Controllers/Navigation/Primary/PrimaryMenuViewController.m
1 file changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/92/157492/1

diff --git a/wikipedia/View 
Controllers/Navigation/Primary/PrimaryMenuViewController.m b/wikipedia/View 
Controllers/Navigation/Primary/PrimaryMenuViewController.m
index 7e1f577..75b87a6 100644
--- a/wikipedia/View Controllers/Navigation/Primary/PrimaryMenuViewController.m
+++ b/wikipedia/View Controllers/Navigation/Primary/PrimaryMenuViewController.m
@@ -156,39 +156,41 @@
         [self.tableData addObject:@{
             @"title": MWLocalizedString(@"main-menu-account-login", nil),
             @"tag": @(PRIMARY_MENU_ITEM_LOGIN)
-        }.mutableCopy];
+        }];
     }
 
     [self.tableData addObjectsFromArray: @[
         @{
             @"title": MWLocalizedString(@"main-menu-show-today", nil),
             @"tag": @(PRIMARY_MENU_ITEM_TODAY)
-        }.mutableCopy,
+        },
         @{
             @"title": MWLocalizedString(@"main-menu-random", nil),
             @"tag": @(PRIMARY_MENU_ITEM_RANDOM)
-        }.mutableCopy,
+        },
         @{
             @"title": MWLocalizedString(@"main-menu-nearby", nil),
             @"tag": @(PRIMARY_MENU_ITEM_NEARBY)
-        }.mutableCopy,
+        },
         @{
             @"title": MWLocalizedString(@"main-menu-show-history", nil),
             @"tag": @(PRIMARY_MENU_ITEM_RECENT)
-        }.mutableCopy,
+        },
         @{
             @"title": MWLocalizedString(@"main-menu-show-saved", nil),
             @"tag": @(PRIMARY_MENU_ITEM_SAVEDPAGES)
-        }.mutableCopy
+        }
     ]];
 }
 
+/*
 -(void)randomizeTitles
 {
     for (NSMutableDictionary *rowData in self.tableData) {
         rowData[@"title"] = [@"abc " randomlyRepeatMaxTimes:50];
     }
 }
+*/
 
 - (NSInteger)tableView:(UITableView *)tableView 
numberOfRowsInSection:(NSInteger)section
 {
@@ -201,7 +203,7 @@
 
     PrimaryMenuTableViewCell *cell = [tableView 
dequeueReusableCellWithIdentifier:cellId];
 
-    NSMutableDictionary *rowData = [self.tableData 
objectAtIndex:indexPath.row];
+    NSDictionary *rowData = [self.tableData objectAtIndex:indexPath.row];
     cell.label.text = rowData[@"title"];
 
     // Set "tag" so if this item is tapped we can have a pointer to the label

-- 
To view, visit https://gerrit.wikimedia.org/r/157492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82d5f0d441bbe679a022deab592d5691fde03314
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits