Filippo Giunchedi has submitted this change and it was merged.

Change subject: mailman: leave used_languages alone, use site_languages
......................................................................


mailman: leave used_languages alone, use site_languages

used_languages is not meant for end user setting and might get changed after a
"dpkg-reconfigure mailman" which in turn is what runs when puppet notices its
value has changed, which means it'd get executed at every puppet run.

  $ echo set mailman/used_languages "ar big5 ca cs da de en es et eu
  fa fi fr gb hi hr hu ia id it ja ko lt nl no pl pt pt_BR ro ru sl sr sv ta tr
  uk vi zh_CN zh_TW" | debconf-communicate
  0 value set
  $ dpkg-reconfigure -fnoninteractive mailman
  [etc etc]
  $ echo get mailman/used_languages | debconf-communicate
  0 ar ast ca cs da de en es et eu fi fr gl he hr hu ia it ja ko lt nl no pl pt
  pt_BR ro ru sk sl sr sv tr uk vi zh_CN zh_TW
  [different value!]

This change sets site_languages which is what the user gets asked upon mailman
installation and is not supposed to change.

Also remove missing/renamed languages "gb" and "big5".

Change-Id: I0850fe52677e74edcde23cf7985135c80ee1db34
---
M manifests/mail.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Filippo Giunchedi: Verified; Looks good to me, approved
  Alexandros Kosiaris: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/manifests/mail.pp b/manifests/mail.pp
index e351a62..f7ab920 100644
--- a/manifests/mail.pp
+++ b/manifests/mail.pp
@@ -174,8 +174,8 @@
             notify => Exec['dpkg-reconfigure mailman'],
         }
 
-        generic::debconf::set { 'mailman/used_languages':
-            value  => 'ar big5 ca cs da de en es et eu fa fi fr gb hi hr hu ia 
id it ja ko lt nl no pl pt pt_BR ro ru sl sr sv ta tr uk vi zh_CN zh_TW',
+        generic::debconf::set { 'mailman/site_languages':
+            value  => 'ar, ast, ca, cs, da, de, en, es, et, eu, fi, fr, gl, 
he, hr, hu, ia, it, ja, ko, lt, nl, no, pl, pt, pt_BR, ro, ru, sk, sl, sr, sv, 
tr, uk, vi, zh_CN, zh_TW',
             notify => Exec['dpkg-reconfigure mailman'],
         }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/156766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0850fe52677e74edcde23cf7985135c80ee1db34
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Mark Bergsma <m...@wikimedia.org>
Gerrit-Reviewer: Thehelpfulone <thehelpfulonew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to