Mhurd has uploaded a new change for review. https://gerrit.wikimedia.org/r/157781
Change subject: iOS 8 needs a couple changes to request location info. ...................................................................... iOS 8 needs a couple changes to request location info. Change-Id: Icfe9a8a2d8abc410846eb6b0b91f64898c995015 --- M wikipedia/View Controllers/Nearby/NearbyViewController.m M wikipedia/Wikipedia-Info.plist 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia refs/changes/81/157781/1 diff --git a/wikipedia/View Controllers/Nearby/NearbyViewController.m b/wikipedia/View Controllers/Nearby/NearbyViewController.m index 347adca..c1163eb 100644 --- a/wikipedia/View Controllers/Nearby/NearbyViewController.m +++ b/wikipedia/View Controllers/Nearby/NearbyViewController.m @@ -114,6 +114,12 @@ self.nearbyDataArray = @[@[]]; self.locationManager = [[CLLocationManager alloc] init]; self.locationManager.activityType = CLActivityTypeFitness; + + // Needed by iOS 8. + if (NSFoundationVersionNumber > NSFoundationVersionNumber_iOS_7_1) { + [self.locationManager requestWhenInUseAuthorization]; + } + self.imageFetchQ = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); self.placeholderImage = [UIImage imageNamed:@"logo-placeholder-nearby.png"]; NSArray *cachePaths = NSSearchPathForDirectoriesInDomains(NSCachesDirectory, NSUserDomainMask, YES); diff --git a/wikipedia/Wikipedia-Info.plist b/wikipedia/Wikipedia-Info.plist index 12de9a8..1678573 100644 --- a/wikipedia/Wikipedia-Info.plist +++ b/wikipedia/Wikipedia-Info.plist @@ -56,5 +56,7 @@ </array> <key>UIViewControllerBasedStatusBarAppearance</key> <true/> + <key>NSLocationWhenInUseUsageDescription</key> + <string></string> </dict> </plist> -- To view, visit https://gerrit.wikimedia.org/r/157781 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icfe9a8a2d8abc410846eb6b0b91f64898c995015 Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd <mh...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits