[MediaWiki-commits] [Gerrit] Use a mock instead of ResourceLoaderContext::newDummyContext() - change (mediawiki...Gadgets)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/158334

Change subject: Use a mock instead of ResourceLoaderContext::newDummyContext()
......................................................................

Use a mock instead of ResourceLoaderContext::newDummyContext()

Change-Id: I0f7a631e58b3fd2cca507e8b251ee5dcff714d4c
---
M tests/GadgetsTest.php
1 file changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/34/158334/1

diff --git a/tests/GadgetsTest.php b/tests/GadgetsTest.php
index 86de239..1cd3394 100644
--- a/tests/GadgetsTest.php
+++ b/tests/GadgetsTest.php
@@ -213,6 +213,15 @@
        }
 
        /**
+        * @return ResourceLoaderContext
+        */
+       private function getMockContext() {
+               return $this->getMockBuilder( 'ResourceLoaderContext' )
+                       ->disableOriginalConstructor()
+                       ->getMock();
+       }
+
+       /**
         * @covers Gadget::getModule
         */
        public function testGetModule() {
@@ -233,7 +242,7 @@
                $this->assertEquals( $data['module']['messages'], 
$m->getMessages(), 'getMessages' );
                $this->assertEquals( $data['module']['position'], 
$m->getPosition(), 'getPosition' );
                $this->assertEquals( LocalGadgetRepo::singleton()->getSource(), 
$m->getSource(), 'getSource' );
-               $this->assertEquals( $pages, $m->getPages( 
ResourceLoaderContext::newDummyContext() ), 'getPages' );
+               $this->assertEquals( $pages, $m->getPages( 
$this->getMockContext() ), 'getPages' );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/158334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f7a631e58b3fd2cca507e8b251ee5dcff714d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: RL2
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits