[MediaWiki-commits] [Gerrit] display for links in widgets changed - change (mediawiki...BlueSpiceExtensions)

[Swidmann (Code Review)]

Swidmann has submitted this change and it was merged.

Change subject: display for links in widgets changed
......................................................................


display for links in widgets changed

* due to the fact, that the widget bar is now bigger, the links can be bigger 
too

Change-Id: Ib1a1e4ebc4197937cdb055bc5de4958d90e05d7f
---
M PagesVisited/PagesVisited.class.php
M SmartList/SmartList.class.php
M WantedArticle/WantedArticle.class.php
M WatchList/WatchList.class.php
4 files changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Smuggli: Looks good to me, but someone else must approve
  Swidmann: Verified; Looks good to me, approved



diff --git a/PagesVisited/PagesVisited.class.php 
b/PagesVisited/PagesVisited.class.php
index 6baef42..c124a7e 100644
--- a/PagesVisited/PagesVisited.class.php
+++ b/PagesVisited/PagesVisited.class.php
@@ -197,7 +197,6 @@
                if ( $oErrorListView->hasItems() ) {
                        return $oErrorListView->execute();
                }
-
                $iCurrentNamespaceId = $oParser->getTitle()->getNamespace();
                $oListView = $this->makePagesVisitedWikiList( $iCount, 
$sNamespaces, $iCurrentNamespaceId, $iMaxTitleLength, $sSortOrder );
                $sOut = $oListView->execute();
@@ -252,7 +251,7 @@
                $iCurrentNamespaceId = $this->getTitle()->getNamespace();
 
                // TODO RBV (04.07.11 15:02): Rework method -> implode() is a 
workaround for legacy code.
-               $oListView = $this->makePagesVisitedWikiList( $iCount, implode( 
',', $aNamespaces ), $iCurrentNamespaceId, 19, $sSortOrder );
+               $oListView = $this->makePagesVisitedWikiList( $iCount, implode( 
',', $aNamespaces ), $iCurrentNamespaceId, 30, $sSortOrder );
                $sOut = $oListView->execute();
 
                if ( !( $oListView instanceof ViewTagError ) ) {
diff --git a/SmartList/SmartList.class.php b/SmartList/SmartList.class.php
index ee74b94..ca37b2f 100644
--- a/SmartList/SmartList.class.php
+++ b/SmartList/SmartList.class.php
@@ -376,7 +376,7 @@
                $oWidgetView
                        ->setId( 'bs-smartlist-edits' )
                        ->setTitle( wfMessage( 'bs-smartlist-lastedits' 
)->plain() )
-                       ->setBody( $this->getYourEdits( 5, 'widget' ) )
+                       ->setBody( $this->getYourEdits( 5, 'widget', 30 ) )
                        ->setTooltip( wfMessage( 'bs-smartlist-lastedits' 
)->plain() )
                        ->setAdditionalBodyClasses( array( 'bs-nav-links', 
'bs-widgetbar-portlet' ) ); //For correct margin and fontsize
 
@@ -891,7 +891,7 @@
         * Generates list of your edits
         * @return string list of edits
         */
-       public function getYourEdits( $iCount, $sOrigin = 'dashboard' ) {
+       public function getYourEdits( $iCount, $sOrigin = 'dashboard', 
$iDisplayLength = 18 ) {
                wfProfileIn( 'BS::'.__METHOD__ );
                $iCount = BsCore::sanitize( $iCount, 0, BsPARAMTYPE::INT );
 
@@ -917,7 +917,7 @@
                                if ( $sOrigin === 'dashboard' ) {
                                        $sHtml = $oTitle->getPrefixedText();
                                } else {
-                                       $sHtml = BsStringHelper::shorten( 
$oTitle->getPrefixedText() , array( 'max-length' => 18, 'position' => 'middle' 
) );
+                                       $sHtml = BsStringHelper::shorten( 
$oTitle->getPrefixedText() , array( 'max-length' => $iDisplayLength, 'position' 
=> 'middle' ) );
                                }
                                $sLink = Linker::link( $oTitle, $sHtml );
                                $aEdits[] = Html::openElement( 'li' ) . $sLink 
. Html::closeElement( 'li' );
diff --git a/WantedArticle/WantedArticle.class.php 
b/WantedArticle/WantedArticle.class.php
index 2f1a327..1b6bf19 100644
--- a/WantedArticle/WantedArticle.class.php
+++ b/WantedArticle/WantedArticle.class.php
@@ -212,7 +212,7 @@
                        $oTitle = $aTitleList[$i];
                        $sWishTitle = BsStringHelper::shorten(
                                $oTitle->getPrefixedText(),
-                               array( 'max-length' => 18, 'position' => 
'middle' )
+                               array( 'max-length' => 30, 'position' => 
'middle' )
                        );
                        $aWikiCodeList[] = 
'*'.BsLinkProvider::makeEscapedWikiLinkForTitle( $oTitle, $sWishTitle );
                }
diff --git a/WatchList/WatchList.class.php b/WatchList/WatchList.class.php
index d03415c..833503d 100644
--- a/WatchList/WatchList.class.php
+++ b/WatchList/WatchList.class.php
@@ -216,7 +216,7 @@
                $oWatchList = $this->fetchWatchlist(
                        $oCurrentUser,
                        $iCount,
-                       20,
+                       30,
                        $sOrder
                );
                $sWatchListWikiText = $oWatchList->execute();

-- 
To view, visit https://gerrit.wikimedia.org/r/158592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a1e4ebc4197937cdb055bc5de4958d90e05d7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Tweichart <weich...@hallowelt.biz>
Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz>
Gerrit-Reviewer: Pigpen <reym...@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: Smuggli <mug...@hallowelt.biz>
Gerrit-Reviewer: Swidmann <widm...@hallowelt.biz>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits